Skip to content

Commit 0831cc7

Browse files
committed
Pull Request 1 of 2 (this is for master branch)
The [compose specification](https://github.com/compose-spec/compose-spec/blob/master/spec.md#ports) says: > Port mapping MUST NOT be used with network_mode: host and doing so MUST result in a runtime error. This rule is being enforced by current versions of docker-compose, and is, in turn causing compose-time errors to appear (eg [Discord post](https://discord.com/channels/638610460567928832/638610461109256194/825336297828777995)). This Pull Request resolves the conflict by commenting-out: * port definitions for dozzle, homebridge, openhab and webthings_gateway; and * the `network_mode: host` directive for home_assistant. Research suggests that Home Assistant only needs host mode to sniff for "Amazon Dash" buttons. According to the [Wikipedia article](https://en.wikipedia.org/wiki/Amazon_Dash) on the topic, the product series was discontinued in 2019. Note. Most services that define host mode either omit ports entirely or already comment them out. This Pull Request is harmonising the remainder. Signed-off-by: Phill Kelley <[email protected]>
1 parent 6b7f143 commit 0831cc7

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

.templates/dozzle/service.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ dozzle:
33
image: amir20/dozzle:latest
44
restart: unless-stopped
55
network_mode: host
6-
ports:
7-
- "8888:8080"
6+
#ports:
7+
# - "8888:8080"
88
volumes:
99
- /var/run/docker.sock:/var/run/docker.sock

.templates/home_assistant/service.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@ home_assistant:
77
volumes:
88
- /etc/localtime:/etc/localtime:ro
99
- ./volumes/home_assistant:/config
10-
network_mode: host
10+
#network_mode: host
1111

.templates/homebridge/service.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ homebridge:
1010
- HOMEBRIDGE_CONFIG_UI_PORT=%WUIPort%
1111
volumes:
1212
- ./volumes/homebridge:/homebridge
13-
ports:
14-
- "4040:4040"
13+
#ports:
14+
# - "4040:4040"
1515
network_mode: host

.templates/openhab/service.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ openhab:
33
container_name: openhab
44
restart: unless-stopped
55
network_mode: host
6-
ports:
7-
- "4050:4050"
8-
- "4051:4051"
6+
#ports:
7+
#- "4050:4050"
8+
#- "4051:4051"
99
volumes:
1010
- "/etc/localtime:/etc/localtime:ro"
1111
- "/etc/timezone:/etc/timezone:ro"

.templates/webthings_gateway/service.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ webthingsio_gateway:
22
image: webthingsio/gateway:latest
33
container_name: webthingsio_gateway
44
network_mode: host
5-
ports:
6-
- "4060:4060"
7-
- "4061:4061"
5+
#ports:
6+
#- "4060:4060"
7+
#- "4061:4061"
88
volumes:
99
- ./volumes/webthingsio_gateway/share:/home/node/.mozilla-iot
1010

0 commit comments

Comments
 (0)