Skip to content

Commit 9a4c1d0

Browse files
authored
Merge pull request #487 from Paraphraser/20220205-prometheus-master
20220206 prometheus - master branch - PR 1 of 2
2 parents 226d95b + 58f1d0f commit 9a4c1d0

File tree

4 files changed

+13
-9
lines changed

4 files changed

+13
-9
lines changed

.templates/prometheus-cadvisor/service.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
prometheus-cadvisor:
2-
container_name: cadvisor
2+
container_name: prometheus-cadvisor
33
image: zcube/cadvisor:latest
44
restart: unless-stopped
55
ports:

.templates/prometheus-nodeexporter/service.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
prometheus-nodeexporter:
2-
container_name: nodeexporter
2+
container_name: prometheus-nodeexporter
33
image: prom/node-exporter:latest
44
restart: unless-stopped
55
expose:

.templates/prometheus/service.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,6 @@ prometheus:
1818
# - --web.console.libraries=/usr/share/prometheus/console_libraries
1919
# - --web.console.templates=/usr/share/prometheus/consoles
2020
depends_on:
21-
- cadvisor
22-
- nodeexporter
21+
- prometheus-cadvisor
22+
- prometheus-nodeexporter
2323

docs/Containers/Prometheus.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ If you do not select all three containers, Prometheus will not start.
4040

4141
When you select *Prometheus* in the IOTstack menu, the service definition includes the three containers:
4242

43-
* *Prometheus*
44-
* *CAdvisor*
45-
* *Node Exporter*
43+
* *prometheus*
44+
* *prometheus-cadvisor;* and
45+
* *prometheus-nodeexporter*.
4646

4747
## <a name="significantFiles"> Significant directories and files </a>
4848

@@ -142,7 +142,7 @@ The remaining instructions in the *Dockerfile* customise the *base image* to pro
142142

143143
The *local image* is instantiated to become your running container.
144144

145-
When you run the `docker images` command after *Prometheus* has been built, you will see two rows for *Prometheus*:
145+
When you run the `docker images` command after *Prometheus* has been built, you *may* see two rows for *Prometheus*:
146146

147147
```bash
148148
$ docker images
@@ -154,7 +154,9 @@ prom/prometheus latest 3f9575991a6c 3 days ago 169MB
154154
* `prom/prometheus` is the *base image*; and
155155
* `iotstack_prometheus` is the *local image*.
156156

157-
You will see the same pattern in Portainer, which reports the *base image* as "unused". You should not remove the *base* image, even though it appears to be unused.
157+
You *may* see the same pattern in Portainer, which reports the *base image* as "unused". You should not remove the *base* image, even though it appears to be unused.
158+
159+
> Whether you see one or two rows depends on the version of `docker-compose` you are using and how your version of `docker-compose` builds local images.
158160
159161
### <a name="dependencies"> Dependencies: *CAdvisor* and *Node Exporter* </a>
160162

@@ -316,6 +318,8 @@ Your existing *Prometheus* container continues to run while the rebuild proceeds
316318

317319
The `prune` is the simplest way of cleaning up. The first call removes the old *local image*. The second call cleans up the old *base image*.
318320

321+
> Whether an old *base image* exists depends on the version of `docker-compose` you are using and how your version of `docker-compose` builds local images.
322+
319323
### <a name="versionPinning"> *Prometheus* version pinning </a>
320324

321325
If you need to pin *Prometheus* to a particular version:

0 commit comments

Comments
 (0)