20220708 Node-RED - old-menu branch - PR 2 of 2 - part 2

Fixes `nodered_list_installed_nodes.sh`. Now relies on `npm` running
inside the container to discover what's installed where.

Signed-off-by: Phill Kelley <[email protected]>

Author: Paraphraser

scripts/nodered_list_installed_nodes.sh

@@ -1,41 +1,47 @@
 #!/usr/bin/env bash
 
-INTERNAL="/usr/src/node-red/node_modules"
-EXTERNAL="$HOME/IOTstack/volumes/nodered/data/node_modules"
-
-echo -e "\nNodes installed by Dockerfile INSIDE the container at $INTERNAL"
-
-CANDIDATES=$(docker exec nodered bash -c "ls -1d $INTERNAL/node-red-*")
-
-for C in $CANDIDATES; do
-
-   NODE=$(basename "$C")
-
-   # is a node of the same name also present externally
-   if [ -d "$EXTERNAL/$NODE" ] ; then
-
-      # yes! the internal node is blocked by the external node
-      echo " BLOCKED: $NODE"
-
-   else
-
-      # no! so that means it's active
-      echo "  ACTIVE: $NODE"
-
+# where Dockerfile installs components INSIDE the container
+DOCKERFILE="/usr/src/node-red"
+
+# paths to the persistent store
+PERSISTENT_INTERNAL="/data"
+PERSISTENT_EXTERNAL="$HOME/IOTstack/volumes/nodered/data"
+
+# the folder in each case containing node modules
+MODULES="node_modules"
+
+# fetch what npm knows about components that form part of the image
+echo -e "\nFetching list of candidates installed via Dockerfile"
+CANDIDATES=$(docker exec nodered bash -c "cd \"$DOCKERFILE\" ; npm list --depth=0 --parseable")
+
+# report
+echo -e "\nComponents built into the image (via Dockerfile)"
+PARENT=$(basename "$DOCKERFILE")
+for CANDIDATE in $CANDIDATES; do
+   COMPONENT=$(basename "$CANDIDATE")
+   if [ "$COMPONENT" != "$PARENT" ] ; then
+      if [ -d "$PERSISTENT_EXTERNAL/$MODULES/$COMPONENT" ] ; then
+         # yes! the internal node is blocked by the external node
+         echo "  BLOCKED: $COMPONENT"
+      else
+         # no! so that means it's active
+         echo "   ACTIVE: $COMPONENT"
+      fi
    fi
-
 done
 
-echo -e "\nNodes installed by Manage Palette OUTSIDE the container at $EXTERNAL"
-
-CANDIDATES=$(ls -1d "$EXTERNAL/node-red-"*)
-
-for C in $CANDIDATES; do
-
-   NODE=$(basename "$C")
-
-   echo " $NODE"
-
+# fetch what npm knows about components that are in the persistent store
+echo -e "\nFetching list of candidates installed via Manage Palette or npm"
+CANDIDATES=$(docker exec nodered bash -c "cd \"$PERSISTENT_INTERNAL\" ; npm list --depth=0 --parseable")
+
+# report
+echo -e "\nComponents in persistent store at\n $PERSISTENT_EXTERNAL/$MODULES"
+PARENT=$(basename "$PERSISTENT_INTERNAL")
+for CANDIDATE in $CANDIDATES; do
+   COMPONENT=$(basename "$CANDIDATE")
+   if [ "$COMPONENT" != "$PARENT" ] ; then
+      echo "  $COMPONENT"
+   fi
 done
 
 echo ""