Fix dashboard bug

Author: phrocker

.github/workflows/maven.yml

@@ -29,7 +29,3 @@ jobs:
         cache: maven
     - name: Build with Maven
       run: mvn -B package --file pom.xml
-
-    # Optional: Uploads the full dependency graph to GitHub to improve the quality of Dependabot alerts this repository can receive
-    - name: Update dependency graph
-      uses: advanced-security/maven-dependency-submission-action@571e99aab1055c2e71a1e2309b9691de18d6b7d6

api/src/main/java/io/sentrius/sso/controllers/api/TerminalApiController.java

@@ -90,12 +90,14 @@ public ResponseEntity<List<HostSystemDTO>> listTerminal(HttpServletRequest reque
     public ResponseEntity<List<TerminalLogOutputDTO>> getOutputSize(
         HttpServletRequest request, HttpServletResponse response) {
         // Check if the current user is a system admin
+        log.info("getOutputSize");
         var currentUser = getOperatingUser(request, response);
         List<TerminalLogOutputDTO> outputData = new ArrayList<>();
         if (AccessUtil.canAccess(currentUser, ApplicationAccessEnum.CAN_MANAGE_APPLICATION)){
             outputData = sessionService.getLogOutputSummary(null);
         } else {
             outputData = sessionService.getLogOutputSummary(currentUser.getUsername());
+            log.info("*** User {} requested terminal log output size", currentUser.getUsername());
         }
 
         return ResponseEntity.ok(outputData);

api/src/main/resources/templates/sso/dashboard.html

@@ -293,10 +293,13 @@ <h3>Open Terminals</h3>
         let maxConnections = 10;
         let currentConnections = 0;
 
-        let tachometerChart; // Chart variable for tachometer
+        let tachometerChart = null; // Chart variable for tachometer
         let outputSizeChart; // Chart variable for output size chart
 
         function createTachometerChart() {
+            if (null == document.getElementById('tachometerChart')){
+                return;
+            }
             const ctx = document.getElementById('tachometerChart').getContext('2d');
             if (tachometerChart){
                 tachometerChart.destroy();
@@ -344,7 +347,7 @@ <h3>Open Terminals</h3>
         }
 
         function updateTachometer(newConnections) {
-            if (newConnections <= maxConnections) {
+            if (newConnections <= maxConnections && null != tachometerChart) {
                 tachometerChart.data.datasets[0].data[0] = newConnections;
                 tachometerChart.data.datasets[0].data[1] = maxConnections - newConnections;
                 tachometerChart.update();
@@ -484,6 +487,7 @@ <h3>Open Terminals</h3>
             });
 
             // Render heatmap with Chart.js
+            if (document.getElementById('heatmap-container')) {
             const ctx = document.getElementById('heatmap-container').getContext('2d');
             new Chart(ctx, {
                 type: 'bar', // Use bar chart to display the heatmap
@@ -517,6 +521,7 @@ <h3>Open Terminals</h3>
                     }
                 }
             });
+            }
         });
     });
 

core/src/main/java/io/sentrius/sso/core/model/security/AccessControlAspect.java

@@ -56,7 +56,7 @@ public void checkLimitAccess(LimitAccess limitAccess) throws SQLException, Gener
             }
 
             if (!canAccess) {
-                throw new ResponseStatusException(HttpStatus.FORBIDDEN, "Access Denied");
+                throw new ResponseStatusException(HttpStatus.FORBIDDEN, "Access Denied to ");
             }
         }
     }