Fix change of type crashes my electron app #11

Author: Septh

README.md

@@ -76,7 +76,7 @@ export default {
 If you're working with monorepos, the `packagePath` is made for you. It can take a path, or an array of paths, to your package.json file(s). If not specified, the default is to start with the current directory's package.json then go up scan for all package.json files in parent directories recursively until either the root git directory is reached or until no other package.json can be found.
 
 #### builtins?: boolean = true
-Set the `builtins` option to `false` if you'd like to use some shims for those. You'll most certainly need an other plugin for this.
+Set the `builtins` option to `false` if you'd like to use some shims for those. You'll most certainly need [an other plugin](https://github.com/rollup/plugins/tree/master/packages/node-resolve/#resolving-built-ins-like-fs) for this.
 
 #### prefixedBuiltins?: boolean | 'strip' = true
 How to handle the `node:` (or sometimes `nodejs:`) prefix some authors use in their code (i.e., `import path from 'node:path'`). If `true` (default), prefixed builtins are treated as their unprefixed equivalent. If `strip`, the prefix is removed from the name and other plugins will never know it was there.

package-lock.json

@@ -1 +1,2 @@
-module.exports = require('./package.json')
+const pkg = require('./package.json')
+module.exports = pkg

package.cjs

@@ -31,7 +31,7 @@
   "engines": {
     "node": ">=14.0.0"
   },
-  "type": "commonjs",
+  "type": "module",
   "main": "./dist/cjs/index.js",
   "module": "./dist/esm/index.js",
   "exports": {
@@ -60,9 +60,6 @@
     "clean": "rimraf dist",
     "prepublishOnly": "npm run lint && npm run clean && npm run build"
   },
-  "dependencies": {
-    "find-up": "^6.2.0"
-  },
   "devDependencies": {
     "@rollup/plugin-commonjs": "^21.0.1",
     "@rollup/plugin-node-resolve": "^13.0.6",
@@ -72,11 +69,15 @@
     "ava-fast-check": "^4.0.2",
     "eslint": "^8.4.1",
     "fast-check": "^2.20.0",
+    "find-up": "^6.2.0",
     "rimraf": "^3.0.2",
     "rollup": "^2.61.1",
     "rollup-plugin-ts": "^2.0.4",
     "ts-node": "^10.4.0",
     "tslib": "^2.3.1",
     "typescript": "^4.5.3"
+  },
+  "dependencies": {
+    "@rollup/plugin-alias": "^3.1.8"
   }
 }

package.json

@@ -1,89 +1,77 @@
 // @ts-check
 import { dirname } from 'path'
-import { builtinModules } from 'module'
+import alias from '@rollup/plugin-alias'
 import resolve from '@rollup/plugin-node-resolve'
 import commonjs from '@rollup/plugin-commonjs'
-import ts from 'rollup-plugin-ts'
+import typescript from 'rollup-plugin-ts'
 
-// https://rollupjs.org/guide/en/#using-untranspiled-config-files
 import pkg from './package.cjs'
 
-/**
- * A mini-plugin that resolves `node:` and `nodejs:` imports to their unprefixed equivalent.
- * @type { import('rollup').PluginImpl }
- */
-function nodeColon() {
-    return {
-        name: 'node-colon',
-        resolveId(id) {
-            for (const scheme of [ 'node:', 'nodejs:' ]) {
-                if (id.startsWith(scheme)) {
-                    return { id: id.slice(scheme.length), external: true}
-                }
-            }
-        }
-    }
+/** @type {import('rollup').OutputOptions} */
+const commonOutput = {
+    sourcemap: false,
+    generatedCode: 'es2015'
 }
 
 /**
- * A mini-plugin that generates a package.json file next to the bundle.
- * @type { import('rollup').PluginImpl<'module' | 'commonjs'> }
+ * @param {'commonjs'|'module'} format
+ * @returns {import('rollup').Plugin[]}
  */
-function emitPkg(type) {
-    return {
+const plugins = format => ([
+    alias({
+        entries: [{
+            find: /^node(?:js)?:(.*)$/,
+            replacement: '$1'
+        }]
+    }),
+    resolve(),
+    commonjs(),
+    typescript({
+        tsconfig: cfg => ({
+            ...cfg,
+            // No need to emit the declarations twice
+            declaration: format === 'module',
+            declarationDir: dirname(pkg.types)
+        })
+    }),
+    {
+        // An inlined mini-plugin that generates a package.json
+        // file next to the bundle with just the 'type' field set.
         name: 'emit-pkg',
         generateBundle() {
             this.emitFile({
                 type: 'asset',
                 fileName: 'package.json',
-                source: JSON.stringify({ type }, undefined, 2)
+                source: JSON.stringify({ type: format })
             })
         }
     }
-}
+])
 
-/** @type {import('rollup').OutputOptions} */
-const commonOutput = {
-    sourcemap: true,
-    generatedCode: 'es2015'
-}
-
-/** @type {import('rollup').RollupOptions} */
-const config = {
-    input: 'src/index.ts',
-    output: [
-        {
+/** @type {import('rollup').RollupOptions[]} */
+const configs = [
+    {
+        input: 'src/index.ts',
+        output: {
             ...commonOutput,
             format: 'commonjs',
             file: pkg.main,
-            exports: 'auto',
-            sourcemap: true,
-            plugins: [
-                emitPkg('commonjs')
-            ]
+            exports: 'default', // externals is exported as default
+            interop: 'default', // How to import external modules?
         },
-        {
+        plugins: plugins('commonjs')
+    },
+    {
+        input: 'src/index.ts',
+        output: {
             ...commonOutput,
             format: 'module',
-            file: pkg.module,
-            sourcemap: true,
-            plugins: [
-                emitPkg('module')
-            ]
+            file: pkg.module
         },
-    ],
-    plugins: [
-        nodeColon(),
-        resolve(),
-        commonjs(),
-        ts({
-            tsconfig: cfg => ({
-                ...cfg,
-                declarationDir: dirname(pkg.types)
-            })
-        })
-    ],
-    external: builtinModules.concat(Object.keys(pkg.dependencies))
-}
+        plugins: plugins('module'),
+        // Leave find-up out of the esm build
+        external: 'find-up'
+    }
+]
 
-export default config
+export default configs

rollup.config.mjs

@@ -34,7 +34,7 @@ export interface ExternalsOptions {
  * Useful when you don't want to bundle node/npm modules with your own code
  * but rather import or require them at runtime.
  */
- export default function externals(options: ExternalsOptions = {}): Plugin {
+export default function externals(options: ExternalsOptions = {}): Plugin {
 
     // Consolidate options
     const config: Required<ExternalsOptions> = {