Skip to content

Commit 4e233eb

Browse files
committed
Typos
1 parent 8775fc8 commit 4e233eb

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ Set the `builtins` option to `false` if you'd like to use some shims/polyfills f
124124
#### builtinsPrefix?: 'add' | 'strip' | 'ignore' = 'add'
125125
How to handle the `node:` scheme used in recent versions of Node (i.e., `import path from 'node:path'`).
126126
- If `add` (the default, recommended), the `node:` scheme is always added if missing. In effect, this dedupes your imports of Node builtins by homogenizing their names to their schemed version.
127-
- If `strip`, the scheme is always removed. In effect, this dedupes your imports of Node builtins by homogenizing their names to their unschemed version. Schemed-only builtins like `node:test` are never stripped.
127+
- If `strip`, the scheme is always removed. In effect, this dedupes your imports of Node builtins by homogenizing their names to their scheme-less version. Schemed-only builtins like `node:test` are never stripped.
128128
- `ignore` will simply leave all builtins imports as written in your code.
129129
> _Note that scheme handling is always applied, regardless of the `builtins` options being enabled or not._
130130
@@ -252,7 +252,7 @@ export default defineConfig({
252252
- This plugin now has a **peer-dependency** on Rollup `^3.0.0 || ^4.0.0`.<br />*If you need Rollup 2 support, please stick to v5.*
253253

254254
#### Breaking changes in version 5
255-
- In previous versions, the `devDeps` option defaulted to `true`.<br>This was practical, but often wrong: devDependencies are meant just for that: being used when developping. Therefore, the `devDeps` option now defaults to `false`, meaning Rollup will include them in your bundle.
255+
- In previous versions, the `devDeps` option defaulted to `true`.<br>This was practical, but often wrong: devDependencies are meant just for that: being used when developing. Therefore, the `devDeps` option now defaults to `false`, meaning Rollup will include them in your bundle.
256256
- As anticipated since v4, the `builtinsPrefix` option now defaults to `'add'`.
257257
- The deprecated `prefixedBuiltins` option has been removed. Use `builtinsPrefix` instead.
258258
- `rollup-plugin-node-externals` no longer depends on the Find-Up package (while this is not a breaking change per se, it can be in some edge situations).

test/_common.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class MockPluginContext {
2525
buildStart = buildStart.handler
2626
if (typeof buildStart === 'function')
2727
return await buildStart.call(this as any, {} as NormalizedInputOptions)
28-
throw new Error('Ooops')
28+
throw new Error('Oops')
2929
}
3030

3131
async resolveId(specifier: string, importer: string | undefined) {
@@ -34,7 +34,7 @@ class MockPluginContext {
3434
resolveId = resolveId.handler
3535
if (typeof resolveId === 'function')
3636
return await resolveId.call(this as any, specifier, importer, { attributes: {}, isEntry: typeof importer === 'string' ? false : true })
37-
throw new Error('Ooops')
37+
throw new Error('Oops')
3838
}
3939

4040
error(err: string | RollupError): never {

test/builtins.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ test("Does NOT mark Node builtins external when builtins=false", async t => {
1919
}
2020
})
2121

22-
test("Does NOT mark Node builtins external when implicitely excluded", async t => {
22+
test("Does NOT mark Node builtins external when implicitly excluded", async t => {
2323
const context = await initPlugin({ exclude: [ 'path', 'node:fs' ]})
2424
for (const builtin of [ 'path', 'node:fs' ]) {
2525
t.like(await context.resolveId(builtin, 'index.js'), {
@@ -55,7 +55,7 @@ test("Removes 'node:' prefix when using builtinsPrefix='strip'", async t => {
5555
}
5656
})
5757

58-
test("Does NOT remove 'node:test' prefix even with builtinsPrefix='add'", async t => {
58+
test("Does NOT remove 'node:test' prefix even with builtinsPrefix='strip'", async t => {
5959
const context = await initPlugin({ builtinsPrefix: 'strip' })
6060
for (const builtin of [ 'node:test' ]) {
6161
t.like(await context.resolveId(builtin, 'index.js'), {

0 commit comments

Comments
 (0)