Skip to content

Commit faab70f

Browse files
committed
fix: add button handlers to dummy embeds for failed fetch cleanup
- Add refresh, copy, and delete button handlers to fetching placeholder embeds - Allows users to delete or refresh embeds that failed to fetch metadata - Previously buttons were visible but non-functional on dummy embeds
1 parent ff97cf9 commit faab70f

File tree

5 files changed

+11
-5
lines changed

5 files changed

+11
-5
lines changed

.husky/pre-commit

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
yarn lint-staged
1+
yarn lint-staged --allow-empty

manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"id": "obsidian-link-embed",
33
"name": "Link Embed",
4-
"version": "2.10.2",
4+
"version": "2.10.3",
55
"minAppVersion": "0.12.0",
66
"description": "This plugin auto-fetches page metadata to embed Notion-style link preview cards.",
77
"author": "SErAphLi",

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "obsidian-link-embed",
3-
"version": "2.10.2",
3+
"version": "2.10.3",
44
"description": "This plugin auto-fetches page metadata to embed Notion-style link preview cards.",
55
"main": "main.js",
66
"scripts": {

src/eventHandlers.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,12 @@ export async function handleEmbedCodeBlock(
6969
// If this is a dummy embed, just render it directly without any expensive operations
7070
if (isDummyEmbed) {
7171
// Render the dummy embed with default aspect ratio
72-
renderEmbed(info, info.image, 1, el, settings);
72+
const dummyEl = renderEmbed(info, info.image, 1, el, settings);
73+
74+
// Add button handlers even for dummy embeds so users can delete failed fetches
75+
addRefreshButtonHandler(dummyEl, info, ctx, settings, vault);
76+
addCopyButtonHandler(dummyEl, info, ctx, vault, settings);
77+
addDeleteButtonHandler(dummyEl, info, ctx, vault, settings);
7378
return; // Exit early, skip all the fetching operations
7479
}
7580

versions.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,5 +59,6 @@
5959
"2.9.4": "0.12.0",
6060
"2.10.0": "0.12.0",
6161
"2.10.1": "0.12.0",
62-
"2.10.2": "0.12.0"
62+
"2.10.2": "0.12.0",
63+
"2.10.3": "0.12.0"
6364
}

0 commit comments

Comments
 (0)