LibGUI: Remove spaces from DynamicWidgetContainer config key

The section_label prop is used as config key. But sometimes it
contains spaces. Spaces in config keys are quite ugly and not
following the .ini spec I think, so this commit filters them out.

Author: bplaat

Userland/Libraries/LibGUI/DynamicWidgetContainer.cpp

@@ -123,7 +123,7 @@ void DynamicWidgetContainer::set_view_state(ViewState state)
         (void)detach_widgets();
 
     if (persist_state())
-        Config::write_i32(config_domain(), "DynamicWidgetContainers"sv, section_label(), to_underlying(state));
+        Config::write_i32(config_domain(), "DynamicWidgetContainers"sv, encode_config_key(), to_underlying(state));
 }
 
 void DynamicWidgetContainer::restore_view_state()
@@ -133,9 +133,9 @@ void DynamicWidgetContainer::restore_view_state()
 
     deferred_invoke([&]() {
         if (is_container_with_individual_order()) {
-            auto order_or_error = JsonValue::from_string(Config::read_string(config_domain(), "DynamicWidgetContainers"sv, section_label()));
+            auto order_or_error = JsonValue::from_string(Config::read_string(config_domain(), "DynamicWidgetContainers"sv, encode_config_key()));
             if (order_or_error.is_error() || !order_or_error.value().is_array()) {
-                Config::remove_key(config_domain(), "DynamicWidgetContainers"sv, section_label());
+                Config::remove_key(config_domain(), "DynamicWidgetContainers"sv, encode_config_key());
                 return;
             }
 
@@ -166,7 +166,7 @@ void DynamicWidgetContainer::restore_view_state()
             for (auto const& child : new_child_order)
                 add_child(*child);
         } else {
-            int persisted_state = Config::read_i32(config_domain(), "DynamicWidgetContainers"sv, section_label(), to_underlying(ViewState::Expanded));
+            int persisted_state = Config::read_i32(config_domain(), "DynamicWidgetContainers"sv, encode_config_key(), to_underlying(ViewState::Expanded));
             set_view_state(static_cast<ViewState>(persisted_state));
         }
         update();
@@ -447,7 +447,12 @@ void DynamicWidgetContainer::swap_widget_positions(NonnullRefPtr<Core::EventRece
     for (auto& child : child_containers())
         new_widget_order.must_append(child.section_label());
 
-    Config::write_string(config_domain(), "DynamicWidgetContainers"sv, section_label(), new_widget_order.serialized<StringBuilder>());
+    Config::write_string(config_domain(), "DynamicWidgetContainers"sv, encode_config_key(), new_widget_order.serialized<StringBuilder>());
+}
+
+String DynamicWidgetContainer::encode_config_key() const
+{
+    return MUST(String::from_byte_string(section_label().replace(" "sv, ""sv, ReplaceMode::All)));
 }
 
 void DynamicWidgetContainer::update_control_button_visibility()

Userland/Libraries/LibGUI/DynamicWidgetContainer.h

@@ -90,6 +90,7 @@ class DynamicWidgetContainer : public Frame {
     void unregister_open_window(NonnullRefPtr<GUI::Window>);
     void set_render_as_move_target(bool);
     void swap_widget_positions(NonnullRefPtr<Core::EventReceiver> source, Gfx::IntPoint destination_positon);
+    String encode_config_key() const;
 
     void handle_mousemove_event(MouseEvent&);
     void handle_mouseup_event(MouseEvent&);