Enable 'IDE0060' warnings, fix issues

Author: Sergio0694

.globalconfig

@@ -69,11 +69,9 @@ dotnet_diagnostic.CA2242.severity = warning
 
 dotnet_diagnostic.IDE0010.severity = none
 dotnet_diagnostic.IDE0130.severity = none
-dotnet_diagnostic.IDE0060.severity = none
 dotnet_diagnostic.IDE1006.severity = warning
 dotnet_diagnostic.IDE0023.severity = none
 dotnet_diagnostic.IDE0024.severity = none
-dotnet_diagnostic.IDE0060.severity = none
 dotnet_diagnostic.IDE0057.severity = none
 dotnet_diagnostic.IDE0046.severity = none
 dotnet_diagnostic.IDE0072.severity = none

samples/ComputeSharp.SwapChain.Shaders.D2D1/ProteanClouds.cs

@@ -67,7 +67,7 @@ private float2 Map(float3 p, float prm1, float2 bsMo)
         return new float2(d + (cl * 0.2f) + 0.25f, cl);
     }
 
-    private float4 Render(float3 ro, float3 rd, float time, float prm1, float2 bsMo)
+    private float4 Render(float3 ro, float3 rd, float prm1, float2 bsMo)
     {
         float4 rez = 0;
         float t = 1.5f;
@@ -162,7 +162,7 @@ public float4 Execute()
         rd.XY = Hlsl.Mul(rd.XY, Rotate((-Disp(scaledTime + 3.5f).X * 0.2f) + bsMo.X));
 
         float prm1 = Hlsl.SmoothStep(-0.4f, 0.4f, Hlsl.Sin(time * 0.3f));
-        float4 scn = Render(ro, rd, scaledTime, prm1, bsMo);
+        float4 scn = Render(ro, rd, prm1, bsMo);
         float3 col = scn.RGB;
 
         col = ILerp(col.BGR, col.RGB, Hlsl.Clamp(1.0f - prm1, 0.05f, 1.0f));

samples/ComputeSharp.SwapChain.Shaders/ProteanClouds.cs

@@ -62,7 +62,7 @@ private float2 Map(float3 p, float prm1, float2 bsMo)
         return new float2(d + (cl * 0.2f) + 0.25f, cl);
     }
 
-    private float4 Render(float3 ro, float3 rd, float time, float prm1, float2 bsMo)
+    private float4 Render(float3 ro, float3 rd, float prm1, float2 bsMo)
     {
         float4 rez = 0;
         float t = 1.5f;
@@ -156,7 +156,7 @@ public float4 Execute()
         rd.XY = Hlsl.Mul(rd.XY, Rotate((-Disp(scaledTime + 3.5f).X * 0.2f) + bsMo.X));
 
         float prm1 = Hlsl.SmoothStep(-0.4f, 0.4f, Hlsl.Sin(time * 0.3f));
-        float4 scn = Render(ro, rd, scaledTime, prm1, bsMo);
+        float4 scn = Render(ro, rd, prm1, bsMo);
         float3 col = scn.RGB;
 
         col = ILerp(col.BGR, col.RGB, Hlsl.Clamp(1.0f - prm1, 0.05f, 1.0f));

src/ComputeSharp.Core/Intrinsics/Hlsl.cs

@@ -1,6 +1,6 @@
 using ComputeSharp.Core.Intrinsics;
 
-#pragma warning disable IDE0022
+#pragma warning disable IDE0022, IDE0060
 
 namespace ComputeSharp;
 

src/ComputeSharp.Core/Primitives/Bool/Bool.cs

@@ -1,6 +1,8 @@
 using System;
 using System.Runtime.InteropServices;
 
+#pragma warning disable IDE0060
+
 namespace ComputeSharp;
 
 /// <summary>

src/ComputeSharp.D2D1.UI.SourceGenerators/CanvasEffectPropertyGenerator.Execute.cs

@@ -59,6 +59,8 @@ public static bool IsCandidatePropertyDeclaration(SyntaxNode node, CancellationT
                 return false;
             }
 
+            token.ThrowIfCancellationRequested();
+
             // The property must be in a type with a base type (as it must derive from CanvasEffect)
             return node.Parent?.IsTypeDeclarationWithOrPotentiallyWithBaseTypes<ClassDeclarationSyntax>() == true;
         }

src/ComputeSharp.D2D1.UI/PixelShaderEffect{T}.ICanvasEffect.cs

@@ -145,7 +145,7 @@ public Rect[] GetRequiredSourceRectangles(
         Span<ComPtr<ABI.Microsoft.Graphics.Canvas.Effects.ICanvasEffect>> canvasEffects = sourceEffects.Length <= 16
             ? stackalloc ComPtr<ABI.Microsoft.Graphics.Canvas.Effects.ICanvasEffect>[16]
             : MemoryMarshal.Cast<IntPtr, ComPtr<ABI.Microsoft.Graphics.Canvas.Effects.ICanvasEffect>>(
-                canvasEffectsAbiArray = ArrayPool<IntPtr>.Shared.Rent(sourceEffects.Length));
+                (canvasEffectsAbiArray = ArrayPool<IntPtr>.Shared.Rent(sourceEffects.Length)).AsSpan());
 
         // Clear the span to ensure no false positives are accidentally disposed
         canvasEffects.Clear();

src/ComputeSharp.D2D1/Shaders/Interop/Effects/PixelShaderEffect.ID2D1EffectImplMethods.cs

@@ -6,6 +6,8 @@
 using ComputeSharp.D2D1.Shaders.Interop.Extensions;
 using ComputeSharp.Win32;
 
+#pragma warning disable IDE0060
+
 namespace ComputeSharp.D2D1.Interop.Effects;
 
 /// <summary>

src/ComputeSharp.SourceGeneration/Helpers/ImmutableArrayBuilder{T}.cs

@@ -229,12 +229,6 @@ public void AddRange(ReadOnlySpan<T> items)
             this.index += items.Length;
         }
 
-        /// <inheritdoc cref="ImmutableArrayBuilder{T}.Clear"/>
-        public void Clear(ReadOnlySpan<T> items)
-        {
-            this.index = 0;
-        }
-
         /// <inheritdoc cref="ImmutableArrayBuilder{T}.Insert"/>
         public void Insert(int index, T item)
         {
@@ -254,9 +248,7 @@ public void Insert(int index, T item)
             this.index++;
         }
 
-        /// <summary>
-        /// Clears the items in the current writer.
-        /// </summary>
+        /// <inheritdoc cref="ImmutableArrayBuilder{T}.Clear"/>
         public void Clear()
         {
             if (typeof(T) != typeof(byte) &&

src/ComputeSharp.SourceGeneration/Helpers/IndentedTextWriter.cs

@@ -8,7 +8,7 @@
 using System.Runtime.CompilerServices;
 using System.Text;
 
-#pragma warning disable IDE0290
+#pragma warning disable IDE0060, IDE0290
 
 namespace ComputeSharp.SourceGeneration.Helpers;