Clippy: Fix needless_pass_by_value

Author: Serial-ATA

src/id3/v2/tag.rs

@@ -1320,7 +1320,7 @@ mod tests {
 		assert!(tag.comment().is_none());
 
 		// Add an empty comment (which is a valid use case).
-		tag.set_comment("".to_owned());
+		tag.set_comment(String::new());
 		assert_eq!(Some(Cow::Borrowed("")), tag.comment());
 
 		// Insert a custom comment frame

src/ogg/opus/mod.rs

@@ -33,7 +33,7 @@ impl OpusFile {
 
 		Ok(Self {
 			properties: if parse_options.read_properties {
-				properties::read_properties(reader, file_information.1, &file_information.2)?
+				properties::read_properties(reader, &file_information.1, &file_information.2)?
 			} else {
 				OpusProperties::default()
 			},

src/ogg/opus/properties.rs

@@ -68,7 +68,7 @@ impl OpusProperties {
 
 pub(in crate::ogg) fn read_properties<R>(
 	data: &mut R,
-	first_page_header: PageHeader,
+	first_page_header: &PageHeader,
 	packets: &Packets,
 ) -> Result<OpusProperties>
 where

src/ogg/speex/mod.rs

@@ -32,7 +32,7 @@ impl SpeexFile {
 
 		Ok(Self {
 			properties: if parse_options.read_properties {
-				properties::read_properties(reader, file_information.1, &file_information.2)?
+				properties::read_properties(reader, &file_information.1, &file_information.2)?
 			} else {
 				SpeexProperties::default()
 			},

src/ogg/speex/properties.rs

@@ -86,7 +86,7 @@ impl SpeexProperties {
 
 pub(in crate::ogg) fn read_properties<R>(
 	data: &mut R,
-	first_page_header: PageHeader,
+	first_page_header: &PageHeader,
 	packets: &Packets,
 ) -> Result<SpeexProperties>
 where

src/ogg/vorbis/mod.rs

@@ -34,7 +34,7 @@ impl VorbisFile {
 
 		Ok(Self {
 			properties: if parse_options.read_properties {
-				properties::read_properties(reader, file_information.1, &file_information.2)?
+				properties::read_properties(reader, &file_information.1, &file_information.2)?
 			} else {
 				VorbisProperties::default()
 			},

src/ogg/vorbis/properties.rs

@@ -85,7 +85,7 @@ impl VorbisProperties {
 
 pub(in crate::ogg) fn read_properties<R>(
 	data: &mut R,
-	first_page_header: PageHeader,
+	first_page_header: &PageHeader,
 	packets: &Packets,
 ) -> Result<VorbisProperties>
 where