Non-Critical Bug in Ore Harvester

[kreezxil]

Information

Minecraft version: 1.21.10
Modloader: Neoforge
NeoForge version: 21.10.64
Environment: Both

Mod name: Ore Harvester
Mod version: 1.5

Description

A logic flaw in the Ore Harvester mod allows players to bypass the intended mining speed penalty (which should scale based on vein size) when vein-mining.

Currently, the mod calculates the increased mining time based on whether the player is crouching. However, the check for the "vein-mine" trigger occurs at the moment of the block break, while the "mining speed" penalty is only applied if the player is crouching during the mining process. This allows a player to mine at normal speed and "tap" crouch at the last second to trigger the harvest.

Steps to Reproduce

1. Locate a large ore vein.
2. Begin mining a single block without crouching (maintaining the tool's default mining speed).
3. Just before the block break animation completes (at the "last moment"), press and hold the Crouch/Shift key.
4. The block finishes breaking while the player is crouching.

Observed Result

The entire vein is harvested instantly (or at the speed of a single block), completely ignoring the "increased time to mine" penalty described in the mod’s documentation. The player receives the benefits of the vein-mine without the "mega-slow" trade-off.

Expected Result

The mining speed should be calculated based on the intent to vein-mine. If a player triggers a vein-mine, the time taken should reflect the total number of blocks in that vein, regardless of when the crouch key was pressed during the break animation.

---

Reference Documentation

"Ore Harvester allows players to mine entire ore veins instantly, by breaking one of the blocks in it while crouching. The time it takes to mine is increased by the amount of ore that's in the vein."

User Conversation Summary

• BaoBuns: "if you don't shift on the block you breaking till you're about to break it you can vein mine it without the speed penalty"
• Kree Zill: "so you're saying just beat on the block normally and then at last moment before it would harvest, hold shift and wala the hole things mines without the mega-slow..."
• BaoBuns: "bingo you got it"

Crash report

There is no crashing.

[UnTypoRandom360]

I use the fabric versions of both this and the tree harvester mod. This also happens in "reverse" where you begin breaking a block while crouching and then you stand up to go back to normal breaking speed whilst still harvesting all the ores/logs. I set increasedHarvestingTimePerOreModifier to 1.0 to make it feel fair, but knowing i can just cheese it kind of ruins it for me lol