Skip to content

Commit d7b96ce

Browse files
committed
fix errors in tests
1 parent 1e81bde commit d7b96ce

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

tests/test_cli.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def test_cli_invalid_pattern(self):
8181
)
8282

8383
self.assertNotEqual(result.exit_code, 0)
84-
self.assertIn("Invalid pattern", result.output)
84+
self.assertIn("Invalid value for '--pattern'", result.output)
8585

8686

8787
if __name__ == "__main__":

tests/test_data_loader.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def test_remote_files(self):
2828
2. loading csv format with pandas
2929
"""
3030
datasets, sort = load_datasets(
31-
"../tracestorm/datasets_config/datasets_config_hf.json"
31+
"tracestorm/datasets_config/datasets_config_hf.json"
3232
)
3333
assert isinstance(datasets, list)
3434
assert isinstance(datasets[0], Dataset) and isinstance(
@@ -42,7 +42,7 @@ def test_remote_files(self):
4242
def test_missing_fields(self):
4343
"""Test loading with missing sort strategy and selection ratio in the config file"""
4444
datasets, sort = load_datasets(
45-
"../tracestorm/datasets_config/datasets_config_missing.json"
45+
"tracestorm/datasets_config/datasets_config_missing.json"
4646
)
4747
assert isinstance(datasets, list) and len(datasets) == 2
4848
assert sort == "random"

tracestorm/cli.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import os
2-
from typing import Tuple
2+
from typing import Tuple, Optional
33

44
import click
55

@@ -21,7 +21,7 @@
2121

2222

2323
def create_trace_generator(
24-
pattern: str, rps: int, duration: int, seed: int
24+
pattern: str, rps: int, duration: int, seed: Optional[int] = None
2525
) -> Tuple[TraceGenerator, str]:
2626
"""
2727
Create appropriate trace generator based on pattern and validate parameters.

tracestorm/datasets_config/datasets_config_missing.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
},
66
"dataset_2": {
77
"file_name": "lmsys/chatbot_arena_conversations",
8-
"prompt_field": "user_prompt"
8+
"prompt_field": "conversation_a"
99
}
1010
}

0 commit comments

Comments
 (0)