Skip to content

Conversation

@allozaur
Copy link

@allozaur allozaur commented Dec 5, 2025

  • Created reusable SearchInput.svelte component in $lib/components/misc/
  • Unified search UI across Models Selector and ChatSidebar
  • Refactored ChatSidebarSearch.svelte to use the new shared component
  • Refactored ModelsSelector.svelte to use ShadCN Popover
  • Enhanced SearchInput.svelte with new props:
    • onKeyDown for keyboard event handling
    • onClose callback with X icon (clears value or closes parent)
  • Added keyboard navigation in Models Selector:
    • ArrowUp/ArrowDown to navigate between options
    • Enter to select highlighted option or highlight first match
    • Visual highlight for currently focused option
  • Focus moves to chat textarea after model selection (instead of popover trigger)

Copy link
Author

@allozaur allozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, @ServeurpersoCom lemme know if it's good :)

@ServeurpersoCom ServeurpersoCom merged commit b00c7f0 into ServeurpersoCom:models-search Dec 5, 2025
12 checks passed
@ServeurpersoCom
Copy link
Owner

Thanks Alek I merge & test

@ServeurpersoCom
Copy link
Owner

Alright, @ServeurpersoCom lemme know if it's good :)

It needs to be constrained by the top of the viewport so it doesn't overflow on mobile, and pass over the famous sidebar button, and it will be perfect!

@allozaur allozaur deleted the allozaur/models-search branch December 5, 2025 22:03
@allozaur
Copy link
Author

allozaur commented Dec 6, 2025

the famous sidebar button

😂

Now it's good

Thanks 😄

@ServeurpersoCom
Copy link
Owner

The correct zindex of the sidebar button will need to be implemented separately because I've noticed the problem is recurring; it will need to be fixed at the source in a small refactoring

@allozaur
Copy link
Author

allozaur commented Dec 6, 2025

The correct zindex of the sidebar button will need to be implemented separately because I've noticed the problem is recurring; it will need to be fixed at the source in a small refactoring

Sure, can be addressed with a direct PR without creating an issue, i think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants