Merge pull request #275 from ServiceNow/xray-fixes

Xray fixes for backward (pre bgym v0.14.2) compatibility

Author: recursix

README.md

@@ -61,7 +61,7 @@ AgentLab Features:
 | [GAIA](https://huggingface.co/spaces/gaia-benchmark/leaderboard) (soon) | - | - | None | - | - | live web | soon |
 | [Mind2Web-live](https://huggingface.co/datasets/iMeanAI/Mind2Web-Live) (soon) | - | - | None | - | - | live web | soon |
 | [MiniWoB](https://miniwob.farama.org/index.html) | [setup](https://github.com/ServiceNow/BrowserGym/blob/main/browsergym/miniwob/README.md) | 125 | Medium | 10 | no | self hosted (static files) | soon |
-| [OSWorld](https://os-world.github.io/) | [setup](https://github.com/ServiceNow/AgentLab/blob/main/src/agentlab/benchmarks/setup.md) | 369 | None | - | - | self hosted  | soon |
+| [OSWorld](https://os-world.github.io/) | [setup](https://github.com/ServiceNow/AgentLab/blob/main/src/agentlab/benchmarks/osworld.md) | 369 | None | - | - | self hosted  | soon |
 
 
 ## 🛠️ Setup AgentLab

src/agentlab/analyze/agent_xray.py

@@ -1312,6 +1312,7 @@ def plot_profiling(ax, step_info_list: list[StepInfo], summary_info: dict, progr
             # NEW: Add wait for page loading visualization
             if (
                 hasattr(prof, "wait_for_page_loading_start")
+                and prof.wait_for_page_loading_start is not None
                 and prof.wait_for_page_loading_start > 0
             ):
                 add_patch(
@@ -1323,7 +1324,11 @@ def plot_profiling(ax, step_info_list: list[StepInfo], summary_info: dict, progr
                 )
 
             # NEW: Add validation visualization
-            if hasattr(prof, "validation_start") and prof.validation_start > 0:
+            if (
+                hasattr(prof, "validation_start")
+                and prof.validation_start is not None
+                and prof.validation_start > 0
+            ):
                 add_patch(
                     ax,
                     prof.validation_start,
@@ -1333,7 +1338,11 @@ def plot_profiling(ax, step_info_list: list[StepInfo], summary_info: dict, progr
                 )
 
             # NEW: Add get observation visualization
-            if hasattr(prof, "get_observation_start") and prof.get_observation_start > 0:
+            if (
+                hasattr(prof, "get_observation_start")
+                and prof.get_observation_start is not None
+                and prof.get_observation_start > 0
+            ):
                 add_patch(
                     ax,
                     prof.get_observation_start,