Skip to content

Commit 85916ec

Browse files
fix: address missing initialization and correct args reference in choose_hints method
1 parent 1e56d49 commit 85916ec

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/agentlab/agents/hint_use_agent/generic_agent.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,14 +325,16 @@ def _get_task_hints(self) -> list[str]:
325325
if self.flags.hint_type == "docs":
326326
if not hasattr(self, "hint_index"):
327327
print("Initializing hint index new time")
328-
self._init()
328+
# @patricebechard It seems _.init() method is missing do we still need it?
329+
# self._init()
329330
if self.flags.hint_query_type == "goal":
330331
query = self.obs_history[-1]["goal_object"][0]["text"]
331332
elif self.flags.hint_query_type == "llm":
332333
queries, _ = self._get_queries()
333334
# HACK: only 1 query supported
334335
query = queries[0]
335336
else:
337+
# @patricebechard: This raises an error with the default value 'direct'
336338
raise ValueError(f"Unknown hint query type: {self.flags.hint_query_type}")
337339

338340
print(f"Query: {query}")
@@ -371,7 +373,7 @@ def _get_task_hints(self) -> list[str]:
371373
goal_or_queries = "\n".join(self.queries)
372374

373375
task_hints = self.hints_source.choose_hints(
374-
self.llm,
376+
self.chat_llm,
375377
self.task_name,
376378
goal_or_queries,
377379
)

0 commit comments

Comments
 (0)