Skip to content

Commit 2eb0c8b

Browse files
minimal cleanup
1 parent 4c663f6 commit 2eb0c8b

File tree

2 files changed

+11
-16
lines changed

2 files changed

+11
-16
lines changed

browsergym/core/src/browsergym/core/hint_labeling.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,18 @@
1+
import json
2+
import logging
13
from importlib import resources
4+
from queue import Queue
25
from typing import Dict, List, Optional
36

4-
from queue import Queue, Empty
57
import playwright.sync_api
68
from pydantic import BaseModel, Field
7-
import logging
8-
import json
9+
910
from . import _get_global_playwright, hint_labeling_files
1011

1112
logger = logging.getLogger(__name__)
1213

1314
HINT_LABELING_DIR = resources.files(hint_labeling_files)
1415

15-
# ------- Data Classes -------
16-
1716

1817
class HintLabelingInputs(BaseModel):
1918
goal: str
@@ -22,13 +21,9 @@ class HintLabelingInputs(BaseModel):
2221
axtree: str
2322
history: List[Dict[str, str]] = Field(default_factory=list)
2423
hint: str = ""
25-
# keep 'suggestions' on Python side, but we’ll map to UI 'suggestions'
2624
suggestions: List[Dict[str, str]] = Field(default_factory=list)
2725

2826

29-
# ------- Hint Labeling backend class -------
30-
31-
3227
class HintLabeling:
3328
def __init__(self, headless: bool, window_size=(600, 1000), *args, **kwargs):
3429

browsergym/core/src/browsergym/utils/obs.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -320,13 +320,13 @@ def dfs(node_idx: int, depth: int, parent_node_filtered: bool, parent_node_name:
320320
pass
321321
else:
322322
node_name = node["name"]["value"]
323-
# if node_name == "":
324-
# try:
325-
# node_name_sources = node["name"]["sources"]
326-
# node_name_sources = [elem for elem in node_name_sources if elem.get("type") == "contents"][0]
327-
# node_name = node_name_sources.get("value", {}).get("value", "")
328-
# except Exception as e:
329-
# logger.warning(f"Failed to extract node name: {e}")
323+
if node_name == "":
324+
try:
325+
node_name_sources = node["name"]["sources"]
326+
node_name_sources = [elem for elem in node_name_sources if elem.get("type") == "contents"][0]
327+
node_name = node_name_sources.get("value", {}).get("value", "")
328+
except Exception as e:
329+
logger.warning(f"Failed to extract node name: {e}")
330330
if "value" in node and "value" in node["value"]:
331331
node_value = node["value"]["value"]
332332
else:

0 commit comments

Comments
 (0)