Refactor LM losses v2 #449
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow/Fast-LLM into train_only_layer_losses
…ow/Fast-LLM into train_only_layer_losses
Removed the targets, class, moved tragets processing to losses, made loss masks more explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Continuation of #425.
logits_scale_factor,target_format,implemenatationin KL and reverse KL, add errors for unsupported cases). Add (reference) torch implementation and rework fused implementations. Also merge the associated tests.get_targetsdirectly intoget_lossentropy_loss_typeparameters instead. Add same parameter to standard LM loss.