Merge pull request #120 from ServiceNow/fix-issue-119-instance-consistency

aldro61 · web-flow · commit 6a6db2a61036 · 2025-12-06T10:04:16.000-08:00
Fix instance consistency in KnowledgeBaseSearchTask
diff --git a/src/browsergym/workarena/tasks/knowledge.py b/src/browsergym/workarena/tasks/knowledge.py
@@ -81,7 +81,7 @@ def __init__(
             )
         else:
             _, requires_install, requires_delete = check_knowledge_base(
-                SNowInstance(),  # instance would be the non-admin instance here and this might break in case user does not have required permissions
+                self.instance,  # Use the instance passed to the task
                 kb_name=KB_NAME,
                 kb_data=self.kb_entries,  # Need admin permissions to check
             )

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ def __init__(`
`81`	`81`	`)`
`82`	`82`	`else:`
`83`	`83`	`_, requires_install, requires_delete = check_knowledge_base(`
`84`		`- SNowInstance(), # instance would be the non-admin instance here and this might break in case user does not have required permissions`
	`84`	`+ self.instance, # Use the instance passed to the task`
`85`	`85`	`kb_name=KB_NAME,`
`86`	`86`	`kb_data=self.kb_entries, # Need admin permissions to check`
`87`	`87`	`)`