rename data files, bug fixes

Author: patricebechard

src/browsergym/workarena/__init__.py

@@ -62,6 +62,13 @@
         task,
     )
 
+# register dynamic guidance tasks
+for task in ALL_WORKARENA_DYNAMIC_GUIDANCE_TASKS:
+    register_task(
+        task.get_task_id(),
+        task,
+    )
+
 workarena_tasks_all = [task_class.get_task_id() for task_class in ALL_WORKARENA_TASKS]
 workarena_tasks_atomic = [task_class.get_task_id() for task_class in ATOMIC_TASKS]
 
@@ -139,7 +146,7 @@ def get_all_tasks_agents(filter="l2", meta_seed=42, n_seed_l1=10, is_agent_curri
 
             return all_task_tuples
         elif level == "dg":
-            for task in ATOMIC_TASKS:
+            for task in ALL_WORKARENA_DYNAMIC_GUIDANCE_TASKS:
                 for seed in rng.randint(0, 1000, n_seed_l1):
                     all_task_tuples.append((task, int(seed)))
 

src/browsergym/workarena/config.py

@@ -233,3 +233,29 @@
 # Report date filter patch flag
 REPORT_PATCH_FLAG = "WORKARENA_DATE_FILTER_PATCH"
 REPORT_FILTER_PROPERTY = "workarena.report.filter.config"
+
+
+# Case tasks
+GET_CASE_STATUS_CONFIG_PATH = str(
+    resources.files(data_files).joinpath("task_configs/get_case_status.json")
+)
+GET_CASE_RESOLUTION_NOTES_CONFIG_PATH = str(
+    resources.files(data_files).joinpath("task_configs/get_case_resnotes.json")
+)
+CLOSE_CASE_CONFIG_PATH = str(
+    resources.files(data_files).joinpath("task_configs/close_case.json")
+)
+FIND_ASSET_UNDER_ACCOUNT_CREATE_CASE_CONFIG_PATH = str(
+    resources.files(data_files).joinpath("task_configs/find_asset_under_account_create_case.json")
+)
+
+# Role tasks
+ASSIGN_ROLE_TO_USER_ADMIN_CONFIG_PATH = str(
+    resources.files(data_files).joinpath("task_configs/assign_role_to_user_admin.json")
+)
+ASSIGN_ROLES_TO_USER_EXPLICIT_CONFIG_PATH = str(
+    resources.files(data_files).joinpath("task_configs/assign_roles_to_user_explicit.json")
+)
+ASSIGN_ROLES_TO_USER_IMPLICIT_CONFIG_PATH = str(
+    resources.files(data_files).joinpath("task_configs/assign_roles_to_user_implicit.json")
+)

…es/task_configs/assign-role-to-user.json …k_configs/assign_role_to_user_admin.jsonsrc/browsergym/workarena/data_files/task_configs/assign-role-to-user.json renamed to src/browsergym/workarena/data_files/task_configs/assign_role_to_user_admin.json src/browsergym/workarena/data_files/task_configs/assign-role-to-user.json renamed to src/browsergym/workarena/data_files/task_configs/assign_role_to_user_admin.json

@@ -1,3 +1,4 @@
+import json
 from typing import Any, Dict, List, Tuple
 
 import playwright.sync_api
@@ -9,28 +10,37 @@
     table_api_call,
     table_column_info,
 )
+from ..config import (
+    CLOSE_CASE_CONFIG_PATH,
+    FIND_ASSET_UNDER_ACCOUNT_CREATE_CASE_CONFIG_PATH,
+    GET_CASE_RESOLUTION_NOTES_CONFIG_PATH,
+    GET_CASE_STATUS_CONFIG_PATH,
+)
 from .base import AbstractServiceNowTask
 
+
 class ServiceNowCaseTask(AbstractServiceNowTask):
-    
 
-    def __init__(self, seed: int, config: Dict[str, Any]) -> None:
-        super().__init__(seed)
+    def __init__(self, seed: int, fixed_config: Dict[str, Any] = None, start_rel_url: str = "/now/nav/ui/home") -> None:
+        super().__init__(seed, start_rel_url=start_rel_url)
         self.task_is_setup = False
-        self.config = config
+        self.config = fixed_config if fixed_config else self.random.choice(self.all_configs())
         self.timeout = 60000
 
     def setup_goal(self, page: playwright.sync_api.Page) -> Tuple[str, dict]:
         goal = self.config["goal"]
         info = self.config
         return goal, info
 
+    def all_configs(self):
+        raise NotImplementedError
+
 
 class GetCaseStatusTask(ServiceNowCaseTask):
 
     def validate(self, page: playwright.sync_api.Page, chat_messages: List[str]) -> Tuple[float, bool, str, dict]:
         state = self.config["state"]
-        if state.lower() in chat_messages[-1]["content"].lower():
+        if state.lower() in chat_messages[-1]["message"].lower():
             return (
                 1,
                 True,
@@ -44,11 +54,14 @@ def validate(self, page: playwright.sync_api.Page, chat_messages: List[str]) ->
             {"message": "The state does not match."},
         )
 
+    def all_configs(self):
+        return json.load(open(GET_CASE_STATUS_CONFIG_PATH))
+
 
 class CloseCaseTask(ServiceNowCaseTask):
-    
-    def __init__(self, seed: int, config: Dict[str, Any]) -> None:
-        super().__init__(seed, config)
+
+    def __init__(self, *args, **kwargs) -> None:
+        super().__init__(*args, **kwargs)
 
         self.initial_state = table_api_call(
             instance=self.instance,
@@ -61,12 +74,12 @@ def __init__(self, seed: int, config: Dict[str, Any]) -> None:
         )["result"][0]["state"]
 
     def validate(self, page: playwright.sync_api.Page, chat_messages: List[str]) -> Tuple[float, bool, str, dict]:
-        
+
         # gather info from config
         case_number = self.config["case_number"]
         resolution_code = self.config["resolution_code"]
         close_notes = self.config["close_notes"]
-        
+
         # Query sn_customerservice_case in ServiceNow
         record = table_api_call(
             instance=self.instance,
@@ -103,7 +116,7 @@ def validate(self, page: playwright.sync_api.Page, chat_messages: List[str]) ->
         )
 
     def teardown(self) -> None:
-        
+
         # revert the state to initial_state
         table_api_call(
             instance=self.instance,
@@ -119,14 +132,17 @@ def teardown(self) -> None:
             },
         )
 
+    def all_configs(self):
+        return json.load(open(CLOSE_CASE_CONFIG_PATH))
+
 
 class GetCaseResolutionNotesTask(ServiceNowCaseTask):
-    
+
     def validate(self, page: playwright.sync_api.Page, chat_messages: List[str]) -> Tuple[float, bool, str, dict]:
         close_notes = self.config["close_notes"]
 
         # check for close_notes
-        if close_notes.lower() in chat_messages[-1]["content"].lower():
+        if close_notes.lower() in chat_messages[-1]["message"].lower():
             return (
                 1,
                 True,
@@ -138,17 +154,21 @@ def validate(self, page: playwright.sync_api.Page, chat_messages: List[str]) ->
             False,
             "",
             {"message": "The close notes do not match."},
-        )    
+        )
+
+    def all_configs(self):
+        return json.load(open(GET_CASE_RESOLUTION_NOTES_CONFIG_PATH))
+
 
 class FindAssetUnderAccountCreateCaseTask(ServiceNowCaseTask):
-    
-    def __init__(self, seed: int, config: Dict[str, Any]) -> None:
-        super().__init__(seed, config)
+
+    def __init__(self, *args, **kwargs) -> None:
+        super().__init__(*args, **kwargs)
         self.record_sys_id = None
 
     def validate(self, page: playwright.sync_api.Page, chat_messages: List[str]) -> Tuple[float, bool, str, dict]:
 
-        customer_account = self.config["customer_account"]    
+        customer_account = self.config["customer_account"]
         assets = [elem.strip() for elem in self.config.get("assets", "").split(",")]
 
         # find customer account sys id
@@ -197,7 +217,6 @@ def validate(self, page: playwright.sync_api.Page, chat_messages: List[str]) ->
         # check for assets
         # TODO: this is not the best way to do it
         for short_description in short_descriptions:
-            print(short_description)
             if all(asset.lower() in short_description.lower() for asset in assets):
                 return (
                     1,
@@ -221,9 +240,13 @@ def teardown(self) -> None:
                 table="sn_customerservice_case",
             )
 
+    def all_configs(self):
+        return json.load(open(FIND_ASSET_UNDER_ACCOUNT_CREATE_CASE_CONFIG_PATH))
+
+
 __TASKS__ = [
     GetCaseStatusTask,
     CloseCaseTask,
     GetCaseResolutionNotesTask,
     FindAssetUnderAccountCreateCaseTask,
-]
+]