fix logic in role tasks validation and teardown

Author: patricebechard

src/browsergym/workarena/tasks/role.py

@@ -79,19 +79,17 @@ def validate(self, page: playwright.sync_api.Page, chat_messages: List[str]) ->
         )
         response.raise_for_status()
         result = response.json().get("result", [])
-        roles = [elem["role"]["display_value"] for elem in result]
+        role_to_sys_id_mapping = {elem["role"]["display_value"]: elem["sys_id"] for elem in result}
         for role in user_roles:
-            if not role in roles:
+            if not role in role_to_sys_id_mapping:
                 return (
                     0,
                     False,
                     "",
                     {"message": "The role does not match."},
                 )
             else:
-                # find which row from result is associated with that role, get sys_id, and save
-                sys_id = next((elem["sys_id"] for elem in result if elem["role"]["display_value"] == role), None)
-                self.created_sysids.append(sys_id)
+                self.created_sysids.append(role_to_sys_id_mapping[role])
         return (
             1,
             True,