remove useless backing property and IList interfaces

Author: mythz

src/ServiceStack.OrmLite/Expressions/IUntypedSqlExpression.cs

@@ -25,8 +25,8 @@ public interface IUntypedSqlExpression : ISqlExpression
         string OrderByExpression { get; set; }
         int? Rows { get; set; }
         int? Offset { get; set; }
-        IList<string> UpdateFields { get; set; }
-        IList<string> InsertFields { get; set; }
+        List<string> UpdateFields { get; set; }
+        List<string> InsertFields { get; set; }
         ModelDefinition ModelDef { get; }
         IUntypedSqlExpression Clone();
 
@@ -74,9 +74,9 @@ public interface IUntypedSqlExpression : ISqlExpression
         IUntypedSqlExpression Limit(int rows);
         IUntypedSqlExpression Limit();
         IUntypedSqlExpression ClearLimits();
-        IUntypedSqlExpression Update(IList<string> updateFields);
+        IUntypedSqlExpression Update(List<string> updateFields);
         IUntypedSqlExpression Update();
-        IUntypedSqlExpression Insert(IList<string> insertFields);
+        IUntypedSqlExpression Insert(List<string> insertFields);
         IUntypedSqlExpression Insert();
 
         IDbDataParameter CreateParam(string name, object value = null, ParameterDirection direction = ParameterDirection.Input, DbType? dbType = null);
@@ -190,13 +190,13 @@ public int? Offset
             set { q.Offset = value; }
         }
 
-        public IList<string> UpdateFields
+        public List<string> UpdateFields
         {
             get { return q.UpdateFields; }
             set { q.UpdateFields = value; }
         }
 
-        public IList<string> InsertFields
+        public List<string> InsertFields
         {
             get { return q.InsertFields; }
             set { q.InsertFields = value; }
@@ -465,7 +465,7 @@ public IUntypedSqlExpression ClearLimits()
             return this;
         }
 
-        public IUntypedSqlExpression Update(IList<string> updateFields)
+        public IUntypedSqlExpression Update(List<string> updateFields)
         {
             q.Update(updateFields);
             return this;
@@ -477,7 +477,7 @@ public IUntypedSqlExpression Update()
             return this;
         }
 
-        public IUntypedSqlExpression Insert(IList<string> insertFields)
+        public IUntypedSqlExpression Insert(List<string> insertFields)
         {
             q.Insert(insertFields);
             return this;

src/ServiceStack.OrmLite/Expressions/SqlExpression.cs

@@ -7,6 +7,7 @@
 using System.Text;
 using System.Collections.ObjectModel;
 using System.Linq.Expressions;
+using System.Runtime.CompilerServices;
 
 namespace ServiceStack.OrmLite
 {
@@ -21,8 +22,8 @@ public abstract partial class SqlExpression<T> : ISqlExpression, IHasUntypedSqlE
         private string havingExpression;
         private string orderBy = string.Empty;
 
-        IList<string> updateFields = new List<string>();
-        IList<string> insertFields = new List<string>();
+        public List<string> UpdateFields { get; set; }
+        public List<string> InsertFields { get; set; }
 
         private string sep = string.Empty;
         protected bool useFieldName = false;
@@ -41,9 +42,13 @@ protected string Sep
 
         public SqlExpression(IOrmLiteDialectProvider dialectProvider)
         {
+            UpdateFields = new List<string>();
+            InsertFields = new List<string>();
+
             modelDef = typeof(T).GetModelDefinition();
             PrefixFieldWithTableName = false;
             WhereStatementWithoutWhereString = false;
+
             DialectProvider = dialectProvider;
             Params = new List<IDbDataParameter>();
             tableDefs.Add(modelDef);
@@ -66,8 +71,8 @@ protected virtual SqlExpression<T> CopyTo(SqlExpression<T> to)
             to.groupBy = groupBy;
             to.havingExpression = havingExpression;
             to.orderBy = orderBy;
-            to.updateFields = updateFields;
-            to.insertFields = insertFields;
+            to.UpdateFields = UpdateFields;
+            to.InsertFields = InsertFields;
             to.modelDef = modelDef;
             to.PrefixFieldWithTableName = PrefixFieldWithTableName;
             to.WhereStatementWithoutWhereString = WhereStatementWithoutWhereString;
@@ -662,9 +667,9 @@ public virtual SqlExpression<T> ClearLimits()
         /// <param name='updatefields'>
         /// IList<string> containing Names of properties to be updated
         /// </param>
-        public virtual SqlExpression<T> Update(IList<string> updateFields)
+        public virtual SqlExpression<T> Update(List<string> updateFields)
         {
-            this.updateFields = updateFields;
+            this.UpdateFields = updateFields;
             return this;
         }
 
@@ -681,7 +686,7 @@ public virtual SqlExpression<T> Update<TKey>(Expression<Func<T, TKey>> fields)
         {
             sep = string.Empty;
             useFieldName = false;
-            updateFields = Visit(fields).ToString().Split(',').ToList();
+            UpdateFields = Visit(fields).ToString().Split(',').ToList();
             return this;
         }
 
@@ -690,7 +695,7 @@ public virtual SqlExpression<T> Update<TKey>(Expression<Func<T, TKey>> fields)
         /// </summary>
         public virtual SqlExpression<T> Update()
         {
-            this.updateFields = new List<string>();
+            this.UpdateFields = new List<string>();
             return this;
         }
 
@@ -707,7 +712,7 @@ public virtual SqlExpression<T> Insert<TKey>(Expression<Func<T, TKey>> fields)
         {
             sep = string.Empty;
             useFieldName = false;
-            insertFields = Visit(fields).ToString().Split(',').ToList();
+            InsertFields = Visit(fields).ToString().Split(',').ToList();
             return this;
         }
 
@@ -717,9 +722,9 @@ public virtual SqlExpression<T> Insert<TKey>(Expression<Func<T, TKey>> fields)
         /// <param name='insertFields'>
         /// IList&lt;string&gt; containing Names of properties to be inserted
         /// </param>
-        public virtual SqlExpression<T> Insert(IList<string> insertFields)
+        public virtual SqlExpression<T> Insert(List<string> insertFields)
         {
-            this.insertFields = insertFields;
+            this.InsertFields = insertFields;
             return this;
         }
 
@@ -728,7 +733,7 @@ public virtual SqlExpression<T> Insert(IList<string> insertFields)
         /// </summary>
         public virtual SqlExpression<T> Insert()
         {
-            this.insertFields = new List<string>();
+            this.InsertFields = new List<string>();
             return this;
         }
 
@@ -901,30 +906,6 @@ public string OrderByExpression
         public int? Rows { get; set; }
         public int? Offset { get; set; }
 
-        public IList<string> UpdateFields
-        {
-            get
-            {
-                return updateFields;
-            }
-            set
-            {
-                updateFields = value;
-            }
-        }
-
-        public IList<string> InsertFields
-        {
-            get
-            {
-                return insertFields;
-            }
-            set
-            {
-                insertFields = value;
-            }
-        }
-
         public ModelDefinition ModelDef
         {
             get
@@ -1733,6 +1714,10 @@ public IDbDataParameter CreateParam(string name,
                 p.Value = DialectProvider.GetParamValue(value, value.GetType());
                 DialectProvider.InitDbParam(p, value.GetType());
             }
+            else
+            {
+                p.Value = DBNull.Value;
+            }
 
             if (dbType != null)
                 p.DbType = dbType.Value;
@@ -1800,17 +1785,34 @@ public static IDbDataParameter CreateParam(this IDbConnection db,
             string name,
             object value=null,
             DbType? dbType=null,
-            bool? isNullable=null,
             byte? precision=null,
             byte? scale=null,
             int? size=null)
         {
-            var dialectProvider = db.GetDialectProvider();
+            return db.GetDialectProvider().CreateParam(name, value, dbType, precision, scale, size);
+        }
 
+        public static IDbDataParameter CreateParam(this IOrmLiteDialectProvider dialectProvider,
+            string name,
+            object value = null,
+            DbType? dbType = null,
+            byte? precision = null,
+            byte? scale = null,
+            int? size = null)
+        {
             var to = dialectProvider.CreateParam();
 
             to.ParameterName = dialectProvider.GetParam(name);
-            to.Value = value;
+
+            if (value != null)
+            {
+                to.Value = dialectProvider.GetParamValue(value, value.GetType());
+                dialectProvider.InitDbParam(to, value.GetType());
+            }
+            else
+            {
+                to.Value = DBNull.Value;
+            }
 
             var valueType = value != null ? value.GetType() : typeof(string);
 
@@ -1828,6 +1830,15 @@ public static IDbDataParameter CreateParam(this IDbConnection db,
 
             return to;
         }
+
+        public static IDbDataParameter AddParam(this IOrmLiteDialectProvider dialectProvider, IDbCommand dbCmd, object value)
+        {
+            var paramName = dbCmd.Parameters.Count.ToString();
+
+            var parameter = dialectProvider.CreateParam(paramName, value);
+            dbCmd.Parameters.Add(parameter);
+            return parameter;
+        }
     }
 }