Change Oracle implementation of InsertAndGetLastInsertId

- do not store value of identity from shared state variable
- throw exception from Oracle GetLastInsertId()
- fix a test, and an auto comment

Author: jessemcdowell-AI

src/ServiceStack.OrmLite.Oracle.Tests/DateTimeColumnTest.cs

@@ -50,11 +50,10 @@ public void Can_store_and_retrieve_DateTime_Value()
 
                 db.Save(obj);
 
-                var id = (int)db.LastInsertId();
-                var target = db.SingleById<Analyze>(id);
+                var target = db.SingleById<Analyze>(obj.Id);
 
                 Assert.IsNotNull(target);
-                Assert.AreEqual(id, target.Id);
+                Assert.AreEqual(obj.Id, target.Id);
                 Assert.AreEqual(obj.Date.ToString("yyyy-MM-dd HH:mm:ss"), target.Date.ToString("yyyy-MM-dd HH:mm:ss"));
                 Assert.AreEqual(obj.Url, target.Url);
             }

src/ServiceStack.OrmLite.Oracle/OracleOrmLiteDialectProvider.cs

@@ -36,7 +36,6 @@ public static OracleOrmLiteDialectProvider Instance
             get { return _instance ?? (_instance = new OracleOrmLiteDialectProvider()); }
         }
 
-        internal long LastInsertId { get; set; }
         protected bool CompactGuid;
 
         internal const string StringGuidDefinition = "VARCHAR2(37)";
@@ -148,13 +147,24 @@ public override IDbConnection CreateConnection(string connectionString, Dictiona
 
         public override long GetLastInsertId(IDbCommand dbCmd)
         {
-            return LastInsertId;
+            throw new NotSupportedException();
         }
 
         public override long InsertAndGetLastInsertId<T>(IDbCommand dbCmd)
         {
             dbCmd.ExecuteScalar();
-            return GetLastInsertId(dbCmd);
+
+            var modelDef = GetModel(typeof(T));
+
+            var primaryKey = modelDef.PrimaryKey;
+            if (primaryKey == null)
+                return 0;
+
+            var identityParameter = (DbParameter)dbCmd.Parameters[this.GetParam(SanitizeFieldNameForParamName(primaryKey.FieldName))];
+            if (identityParameter == null)
+                return 0;
+
+            return Convert.ToInt64(identityParameter.Value);
         }
 
         public override void SetDbValue(FieldDefinition fieldDef, IDataReader reader, int colIndex, object instance)
@@ -897,13 +907,11 @@ private object GetNextValue(IDbConnection connection, IDbTransaction transaction
                 Object retObj;
                 if (long.TryParse(value.ToString(), out nv))
                 {
-                    LastInsertId = nv;
-                    retObj = LastInsertId;
+                    retObj = nv;
                 }
                 else
                 {
-                    LastInsertId = 0;
-                    retObj = value;
+                    retObj = 0;
                 }
                 return retObj;
             }
@@ -913,7 +921,6 @@ private object GetNextValue(IDbConnection connection, IDbTransaction transaction
                 dbCmd.Transaction = transaction;
                 dbCmd.CommandText = string.Format("SELECT {0}.NEXTVAL FROM dual", Quote(sequence));
                 var result = dbCmd.LongScalar();
-                LastInsertId = result;
                 return result;
             }
         }

src/ServiceStack.OrmLite/OrmLiteWriteConnectionExtensions.cs

@@ -2,6 +2,7 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Data;
+using ServiceStack.Data;
 
 namespace ServiceStack.OrmLite
 {
@@ -281,7 +282,7 @@ public static int DeleteById<T>(this IDbConnection dbConn, object id)
 
         /// <summary>
         /// Delete 1 row by the PrimaryKey where the rowVersion matches the optimistic concurrency field. 
-        /// Will throw <exception cref="RowModifiedException">RowModefiedExeption</exception> if the 
+        /// Will throw <exception cref="OptimisticConcurrencyException">RowModefiedExeption</exception> if the 
         /// row does not exist or has a different row version.
         /// E.g: <para>db.DeleteById&lt;Person&gt;(1)</para>
         /// </summary>