Remove magic behavior for bools in db.UpdateNonDefault(), don't compare default values in nullable types

Author: mythz

src/ServiceStack.OrmLite/Expressions/SqlExpression.cs

@@ -744,9 +744,8 @@ public virtual string ToUpdateStatement(T item, bool excludeDefaults = false)
                 if (updateFields.Count > 0 && !updateFields.Contains(fieldDef.Name)) continue; // added
 
                 var value = fieldDef.GetValue(item);
-                if (excludeDefaults 
-                    && (value == null || value.Equals(value.GetType().GetDefaultValue()))
-                    && !(value is bool)) 
+                if (excludeDefaults
+                    && (value == null || (!fieldDef.IsNullable && value.Equals(value.GetType().GetDefaultValue()))))
                     continue;
 
                 fieldDef.GetQuotedValue(item, DialectProvider);
@@ -760,6 +759,9 @@ public virtual string ToUpdateStatement(T item, bool excludeDefaults = false)
                     .Append(DialectProvider.GetQuotedValue(value, fieldDef.FieldType));
             }
 
+            if (setFields.Length == 0)
+                throw new ArgumentException("No non-null or non-default values were provided for type: " + typeof(T).Name);
+
             return string.Format("UPDATE {0} SET {1} {2}",
                 DialectProvider.GetQuotedTableName(modelDef), setFields, WhereExpression);
         }

tests/ServiceStack.OrmLite.Tests/OrmLiteUpdateTests.cs

@@ -213,10 +213,16 @@ public void Can_UpdateOnly_bool_columns()
             {
                 db.DropAndCreateTable<PocoWithBool>();
 
-                db.Insert(new PocoWithBool { Id = 1, Bool = true });
-                db.UpdateNonDefaults(new PocoWithBool { Bool = false }, x => x.Id == 1);
+                db.Insert(new PocoWithBool { Id = 1, Bool = false });
                 var row = db.SingleById<PocoWithBool>(1);
                 Assert.That(row.Bool, Is.False);
+
+                db.UpdateNonDefaults(new PocoWithBool { Bool = true }, x => x.Id == 1);
+                row = db.SingleById<PocoWithBool>(1);
+                Assert.That(row.Bool, Is.True);
+
+                Assert.Throws<ArgumentException>(() => 
+                    db.UpdateNonDefaults(new PocoWithBool { Bool = false }, x => x.Id == 1));
             }
         }
 
@@ -228,11 +234,37 @@ public void Can_UpdateOnly_nullable_bool_columns()
                 db.DropAndCreateTable<PocoWithNullableBool>();
 
                 db.Insert(new PocoWithNullableBool { Id = 1, Bool = true });
-                db.UpdateNonDefaults(new PocoWithNullableBool { Bool = false }, x => x.Id == 1);
                 var row = db.SingleById<PocoWithNullableBool>(1);
+                Assert.That(row.Bool, Is.True);
+
+                db.UpdateNonDefaults(new PocoWithNullableBool { Bool = false }, x => x.Id == 1);
+                row = db.SingleById<PocoWithNullableBool>(1);
                 Assert.That(row.Bool, Is.False);
             }
         }
+
+        public class PocoWithNullableInt
+        {
+            public int Id { get; set; }
+            public int? Int { get; set; }
+        }
+
+        [Test]
+        public void Can_UpdateOnly_nullable_int_columns()
+        {
+            using (var db = OpenDbConnection())
+            {
+                db.DropAndCreateTable<PocoWithNullableInt>();
+
+                db.Insert(new PocoWithNullableInt { Id = 1, Int = 1 });
+                var row = db.SingleById<PocoWithNullableInt>(1);
+                Assert.That(row.Int, Is.EqualTo(1));
+                
+                db.UpdateNonDefaults(new PocoWithNullableInt { Int = 0 }, x => x.Id == 1);
+                row = db.SingleById<PocoWithNullableInt>(1);
+                Assert.That(row.Int, Is.EqualTo(0));
+            }
+        }
     }
 
     [CompositeIndex("FirstName", "LastName")]