Add new SqlServer2008Dialect.Provider for SQLServer 2008 specific behavior

Author: mythz

src/ServiceStack.OrmLite.SqlServer/SqlServer2008OrmLiteDialectProvider.cs

@@ -0,0 +1,37 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace ServiceStack.OrmLite.SqlServer 
+{
+    public class SqlServer2008OrmLiteDialectProvider : SqlServerOrmLiteDialectProvider
+    {
+        public new static SqlServer2008OrmLiteDialectProvider Instance = new SqlServer2008OrmLiteDialectProvider();
+
+        public override string SqlConcat(IEnumerable<object> args)
+        {
+            var sb = new StringBuilder();
+            foreach (var arg in args)
+            {
+                if (sb.Length > 0)
+                    sb.Append(" + ");
+
+                var argType = arg.GetType();
+                if (argType.IsNumericType() || argType == typeof(bool) || argType == typeof(DateTime) || argType == typeof(TimeSpan))
+                {
+                    sb.AppendFormat("'{0}'", arg);
+                }
+                else if (arg is string s && s.StartsWith("'") || arg is PartialSqlString p)
+                {
+                    sb.Append(arg);
+                }
+                else
+                {
+                    sb.Append($"CAST({arg} AS VARCHAR(MAX))");
+                }
+            }
+            
+            return sb.ToString();
+        }
+    }
+}

src/ServiceStack.OrmLite.SqlServer/SqlServerDialect.cs

@@ -7,6 +7,11 @@ public static class SqlServerDialect
         public static IOrmLiteDialectProvider Provider => SqlServerOrmLiteDialectProvider.Instance;
     }
 
+    public static class SqlServer2008Dialect
+    {
+        public static IOrmLiteDialectProvider Provider => SqlServer2008OrmLiteDialectProvider.Instance;
+    }
+
     public static class SqlServer2012Dialect
     {
         public static IOrmLiteDialectProvider Provider => SqlServer2012OrmLiteDialectProvider.Instance;

tests/ServiceStack.OrmLite.Tests/Async/SqlExpressionTests.cs

@@ -83,7 +83,7 @@ public void Can_select_limit_on_Table_with_References()
             if (Dialect == Dialect.MySql)
                 return; //= This version of MySQL doesn't yet support 'LIMIT & IN/ALL/ANY/SOME subquery'
 
-            if (Dialect == Dialect.SqlServer)
+            if ((Dialect & Dialect.AnySqlServer) == Dialect)
                 return; // generates Windowing function "... WHERE CustomerId IN (SELECT * FROM ...)" 
                         // when should generate "... WHERE CustomerId IN (SELECT Id FROM ...)" 
                         // both on .NET and .NET Core
@@ -132,7 +132,7 @@ public async Task Can_select_limit_on_Table_with_References_Async()
             if (Dialect == Dialect.MySql)
                 return; //= This version of MySQL doesn't yet support 'LIMIT & IN/ALL/ANY/SOME subquery'
 
-            if (Dialect == Dialect.SqlServer)
+            if ((Dialect & Dialect.AnySqlServer) == Dialect)
                 return; // generates Windowing function "... WHERE CustomerId IN (SELECT * FROM ...)" 
                         // when should generate "... WHERE CustomerId IN (SELECT Id FROM ...)" 
                         // both on .NET and .NET Core

tests/ServiceStack.OrmLite.Tests/Expression/SqlExpressionTests.cs

@@ -612,7 +612,8 @@ public void Can_select_limit_on_Table_with_References()
             if (Dialect == Dialect.MySql) return;
 
             //Only one expression can be specified in the select list when the subquery is not introduced with EXISTS.
-            if (Dialect == Dialect.SqlServer) return;
+            if ((Dialect & Dialect.AnySqlServer) == Dialect)
+                return;
 
             using (var db = OpenDbConnection())
             {

tests/ServiceStack.OrmLite.Tests/LoadReferencesJoinTests.cs

@@ -712,7 +712,7 @@ public void Can_load_references_with_OrderBy_and_Paging()
             //This version of MariaDB doesn't yet support 'LIMIT & IN/ALL/ANY/SOME subquery'
             if (Dialect == Dialect.MySql)
                 return;
-            if (Dialect == Dialect.SqlServer) //Only one expression can be specified in the select list when the subquery is not introduced with EXISTS.
+            if ((Dialect & Dialect.AnySqlServer) == Dialect) //Only one expression can be specified in the select list when the subquery is not introduced with EXISTS.
                 return;
 
             db.DropTable<ParentSelf>();

tests/ServiceStack.OrmLite.Tests/MaxDataTypeTests.cs

@@ -11,13 +11,14 @@ public class MaxDataTypeTests : OrmLiteTestBase
         public void Can_insert_and_select_max_values()
         {
             //OrmLiteConfig.ThrowOnError = true;
+            var isSqlServer = (Dialect & Dialect.AnySqlServer) == Dialect;
 
             var model = new ModelWithFieldsOfDifferentTypes
             {
                 Int = int.MaxValue,
                 Long = long.MaxValue,
                 Double = double.MaxValue,
-                Decimal = Dialect != Dialect.SqlServer && Dialect != Dialect.SqlServer2012 && Dialect != Dialect.Sqlite
+                Decimal = !isSqlServer && Dialect != Dialect.Sqlite
                     ? Decimal.MaxValue
                     : long.MaxValue,
                 DateTime = Dialect != Dialect.MySql 

tests/ServiceStack.OrmLite.Tests/OrmLiteSaveTests.cs

@@ -34,7 +34,7 @@ public void Save_populates_AutoIncrementId()
         public void Can_disable_AutoIncrement_field()
         {
             //Can't insert in identity column
-            if (Dialect == Dialect.SqlServer || Dialect == Dialect.SqlServer2012)
+            if ((Dialect & Dialect.AnySqlServer) == Dialect)
                 return;
 
             using (var db = OpenDbConnection())

tests/ServiceStack.OrmLite.Tests/OrmLiteTestBase.cs

@@ -135,6 +135,8 @@ private OrmLiteConnectionFactory Init()
                     return dbFactory;
                 case Dialect.SqlServer:
                     return Init(Config.SqlServerBuildDb, SqlServerDialect.Provider);
+                case Dialect.SqlServer2008:
+                    return Init(Config.SqlServerBuildDb, SqlServer2008Dialect.Provider);
                 case Dialect.SqlServer2012:
                     return Init(Config.SqlServerBuildDb, SqlServer2012Dialect.Provider);
                 case Dialect.MySql:

tests/ServiceStack.OrmLite.Tests/TestHelpers.cs

@@ -1,19 +1,23 @@
+using System;
 using System.Collections.Generic;
 using System.Data;
 
 namespace ServiceStack.OrmLite.Tests
 {
+    [Flags]
     public enum Dialect
     {
-        Sqlite,
-        SqlServer,
-        SqlServer2012,
-        PostgreSql,
-        MySql,
-        SqlServerMdf,
-        Oracle,
-        Firebird,
-        VistaDb,
+        Sqlite = 1,
+        SqlServer = 2,
+        SqlServer2008 = 4,
+        SqlServer2012 = 8,
+        PostgreSql = 16,
+        MySql = 32,
+        SqlServerMdf = 64,
+        Oracle = 128,
+        Firebird = 256,
+        VistaDb = 512,
+        AnySqlServer = SqlServer | SqlServer2008 | SqlServer2012 | SqlServerMdf,
     }
 
     public static class TestHelpers