Only execute Update/Insert filters once in SaveAll APIs

Author: mythz

src/ServiceStack.OrmLite/Async/OrmLiteWriteCommandExtensionsAsync.cs

@@ -415,8 +415,6 @@ internal static async Task<int> SaveAllAsync<T>(this IDbCommand dbCmd, IEnumerab
                     var id = modelDef.GetPrimaryKey(row);
                     if (id != defaultIdValue && existingRowsMap.ContainsKey(id))
                     {
-                        OrmLiteConfig.UpdateFilter?.Invoke(dbCmd, row);
-
                         await dbCmd.UpdateAsync(row, token, null);
                     }
                     else
@@ -430,8 +428,6 @@ internal static async Task<int> SaveAllAsync<T>(this IDbCommand dbCmd, IEnumerab
                         }
                         else
                         {
-                            OrmLiteConfig.InsertFilter?.Invoke(dbCmd, row);
-
                             await dbCmd.InsertAsync(row, commandFilter:null, selectIdentity:false, token:token);
                         }
 

src/ServiceStack.OrmLite/OrmLiteWriteCommandExtensions.cs

@@ -910,7 +910,6 @@ internal static int SaveAll<T>(this IDbCommand dbCmd, IEnumerable<T> objs)
                     var id = modelDef.GetPrimaryKey(row);
                     if (id != defaultIdValue && existingRowsMap.ContainsKey(id))
                     {
-                        OrmLiteConfig.UpdateFilter?.Invoke(dbCmd, row);
                         dbCmd.Update(row);
                     }
                     else
@@ -925,7 +924,6 @@ internal static int SaveAll<T>(this IDbCommand dbCmd, IEnumerable<T> objs)
                         }
                         else
                         {
-                            OrmLiteConfig.InsertFilter?.Invoke(dbCmd, row);
                             dbCmd.Insert(row, commandFilter: null);
                         }
 

tests/ServiceStack.OrmLite.Tests/OrmLiteFiltersTests.cs

@@ -1,6 +1,9 @@
 using System;
+using System.Collections.Generic;
+using System.Threading.Tasks;
 using NUnit.Framework;
 using ServiceStack.DataAnnotations;
+using ServiceStack.Text;
 
 namespace ServiceStack.OrmLite.Tests
 {
@@ -88,6 +91,33 @@ public void Does_call_Filters_on_insert_and_update()
             OrmLiteConfig.InsertFilter = OrmLiteConfig.UpdateFilter = null;
         }
 
+        [Test]
+        public async Task Does_fire_filters_for_SaveAll()
+        {
+            var sbInsert = new List<string>(); 
+            var sbUpdate = new List<string>();
+            OrmLiteConfig.InsertFilter = (cmd, o) => sbInsert.Add(cmd.CommandText);
+            OrmLiteConfig.UpdateFilter = (cmd, o) => sbUpdate.Add(cmd.CommandText);
+
+            using (var db = OpenDbConnection())
+            {
+                db.DropAndCreateTable<AuditTableA>();
+                await db.SaveAllAsync(new[] {
+                    new AuditTableA {Id = 1, ModifiedBy = "A1"},
+                    new AuditTableA {Id = 2, ModifiedBy = "B1"},
+                });
+                
+                Assert.That(sbInsert.Count, Is.EqualTo(2));
+
+                await db.SaveAllAsync(new[] {
+                    new AuditTableA {Id = 1, ModifiedBy = "A2"},
+                    new AuditTableA {Id = 2, ModifiedBy = "B2"},
+                });
+                
+                Assert.That(sbUpdate.Count, Is.EqualTo(2));
+            }
+        }
+
         [Test]
         public void Does_call_Filters_on_Save()
         {