Change LoadSelect to allow specifying empty include string array to load no references

Author: mythz

src/ServiceStack.OrmLite/OrmLiteReadCommandExtensions.cs

@@ -898,15 +898,15 @@ public static void LoadReferences<T>(this IDbCommand dbCmd, T instance, string[]
             var loadRef = new LoadReferencesSync<T>(dbCmd, instance);
             var fieldDefs = loadRef.FieldDefs;
 
-            if (!include.IsEmpty())
+            if (include != null)
             {
                 // Check that any include values aren't reference fields of the specified type
                 var fields = fieldDefs.Select(q => q.FieldName);
-                var invalid = include.Except<string>(fields).ToList();
+                var invalid = include.Except(fields).ToList();
                 if (invalid.Count > 0)
                     throw new ArgumentException("Fields '{0}' are not Reference Properties of Type '{1}'".Fmt(invalid.Join("', '"), typeof(T).Name));
 
-                fieldDefs = fieldDefs.Where(fd => include.Contains(fd.FieldName)).ToList();
+                fieldDefs = fieldDefs.Where(f => include.Contains(f.FieldName)).ToList();
             }
 
             foreach (var fieldDef in fieldDefs)
@@ -929,15 +929,15 @@ internal static List<Into> LoadListWithReferences<Into, From>(this IDbCommand db
             var loadList = new LoadListSync<Into, From>(dbCmd, expr);
 
             var fieldDefs = loadList.FieldDefs;
-            if (!include.IsEmpty())
+            if (include != null)
             {
                 // Check that any include values aren't reference fields of the specified From type
                 var fields = fieldDefs.Select(q => q.FieldName);
-                var invalid = include.Except<string>(fields).ToList();
+                var invalid = include.Except(fields).ToList();
                 if (invalid.Count > 0)
                     throw new ArgumentException("Fields '{0}' are not Reference Properties of Type '{1}'".Fmt(invalid.Join("', '"), typeof(From).Name));
 
-                fieldDefs = loadList.FieldDefs.Where(fd => include.Contains(fd.FieldName)).ToList();
+                fieldDefs = loadList.FieldDefs.Where(f => include.Contains(f.FieldName)).ToList();
             }
 
             foreach (var fieldDef in fieldDefs)

tests/ServiceStack.OrmLite.Tests/LoadReferencesTests.cs

@@ -667,6 +667,14 @@ public void Can_load_only_included_references()
             Assert.That(dbCustomer.Orders, Is.Null);
             Assert.That(dbCustomer.PrimaryAddress, Is.Not.Null);
 
+            dbCustomers = db.LoadSelect<Customer>(q => q.Id == customer.Id, include: new string[0]);
+            Assert.That(dbCustomers.All(x => x.Orders == null));
+            Assert.That(dbCustomers.All(x => x.PrimaryAddress == null));
+
+            dbCustomer = db.LoadSingleById<Customer>(customer.Id, include: new string[0]);
+            Assert.That(dbCustomer.Name, Is.EqualTo("Customer 1"));
+            Assert.That(dbCustomer.Orders, Is.Null);
+            Assert.That(dbCustomer.PrimaryAddress, Is.Null);
 
             // Invalid field name
             try