Order By PK in SQL Server 2012 for limit requests without explicit OrderBy

Author: mythz

src/ServiceStack.OrmLite.SqlServer/SqlServer2012OrmLiteDialectProvider.cs

@@ -22,7 +22,13 @@ public override string ToSelectStatement(ModelDefinition modelDef,
             if (offset != null || rows != null)
             {
                 if (orderByExpression.IsEmpty())
-                    sb.Append(" ORDER BY 1");
+                {
+                    var orderBy = offset == null && rows == 1 //Avoid for Single requests
+                        ? "1"
+                        : this.GetQuotedColumnName(modelDef, modelDef.PrimaryKey);
+
+                    sb.Append(" ORDER BY " + orderBy);
+                }
 
                 sb.Append(" OFFSET ").Append(offset.GetValueOrDefault()).Append(" ROWS");
 

src/ServiceStack.OrmLite.SqlServerTests/Converters/InheritanceTest.cs

@@ -0,0 +1,59 @@
+using System;
+using System.Collections.Generic;
+using Microsoft.SqlServer.Types;
+using NUnit.Framework;
+
+namespace ServiceStack.OrmLite.SqlServerTests.Converters
+{
+    public class InheritanceTest : SqlServerConvertersOrmLiteTestBase
+    {
+        public class GeoSuper
+        {
+            public long Id { get; set; }
+            public string Other { get; set; }
+        }
+
+        public class GeoTest : GeoSuper
+        {
+            public SqlGeography Location { get; set; }
+            public SqlGeography NullLocation { get; set; }
+            public SqlGeometry Shape { get; set; }
+        }
+
+        [Test]
+        public void Can_limit_on_inherited_Type()
+        {
+            InsertData(100);
+            List<GeoTest> data = null;
+            using (var db = OpenDbConnection())
+            {
+                data = db.Select(db.From<GeoTest>().Limit(0, int.MaxValue));
+            }
+
+            Assert.IsNotNull(data);
+            Assert.IsTrue(data.Count == 100);
+        }
+
+        private void InsertData(int count)
+        {
+            using (var db = OpenDbConnection())
+            {
+                db.DropAndCreateTable<GeoTest>();
+
+                for (var i = 0; i < count; i++)
+                {
+                    db.Insert(new GeoTest { Id = i, Location = RandomPosition() });
+                }
+            }
+        }
+
+        private SqlGeography RandomPosition()
+        {
+            var rand = new Random(DateTime.Now.Millisecond * (int)DateTime.Now.Ticks);
+            double lat = Math.Round(rand.NextDouble() * 160 - 80, 6);
+            double lon = Math.Round(rand.NextDouble() * 360 - 180, 6);
+            var result = SqlGeography.Point(lat, lon, 4326).MakeValid();
+            return result;
+        }
+    }
+}

src/ServiceStack.OrmLite.SqlServerTests/ServiceStack.OrmLite.SqlServerTests.csproj

@@ -85,6 +85,7 @@
     <Compile Include="DateTimeOffsetTests.cs" />
     <Compile Include="InsertParam_GetLastInsertId.cs" />
     <Compile Include="Issues\CustomSelectWithPagingIssue.cs" />
+    <Compile Include="Converters\InheritanceTest.cs" />
     <Compile Include="Issues\JamesGeoIssue.cs" />
     <Compile Include="Issues\SerializationTests.cs" />
     <Compile Include="NestedTransactions.cs" />

tests/ServiceStack.OrmLite.Tests/CaptureSqlCommandFilterTests.cs

@@ -126,7 +126,7 @@ public void Can_capture_command_all_Single_Apis()
                 Assert.That(captured.SqlCommandHistory.Last().Sql.NormalizeSql(),
                     Is.EqualTo("select id, firstname, lastname, age  from person where (age = {0}) limit 1".Fmt(p)).  //Sqlite
                     Or.EqualTo("select top 1 id, firstname, lastname, age  from person where (age = {0})".Fmt(p)).    //SQLServer < 2012
-                    Or.EqualTo("select id, firstname, lastname, age  from person where (age = {0}) order by 1 offset 0 rows fetch next 1 rows only".Fmt(p)). //SQLServer >= 2012
+                    Or.EqualTo("select id, firstname, lastname, age  from person where (age = {0}) order by person.id offset 0 rows fetch next 1 rows only".Fmt(p)). //SQLServer >= 2012
                     Or.EqualTo("select first 1 id, firstname, lastname, age  from person where (age = {0})".Fmt(p))); //Firebird
 
             i++; db.ExistsFmt<Person>("Age = {0}", 42);

tests/ServiceStack.OrmLite.Tests/CaptureSqlFilterTests.cs

@@ -125,7 +125,7 @@ public void Can_capture_all_Single_Apis()
                     Is.EqualTo("select id, firstname, lastname, age  from person where (age = {0}) limit 1".Fmt(p)). //sqlite
                     Or.EqualTo("select top 1 id, firstname, lastname, age  from person where (age = {0})".Fmt(p)).   //SqlServer
                     Or.EqualTo("select first 1 id, firstname, lastname, age  from person where (age = {0})".Fmt(p)).  //Firebird
-                    Or.EqualTo("select id, firstname, lastname, age  from person where (age = {0}) order by 1 offset 0 rows fetch next 1 rows only".Fmt(p)). //VistaDB
+                    Or.EqualTo("select id, firstname, lastname, age  from person where (age = {0}) order by person.id offset 0 rows fetch next 1 rows only".Fmt(p)). //VistaDB
                     Or.EqualTo("select * from (\r select ssormlite1.*, rownum rnum from (\r select id, firstname, lastname, age  from person where (age = {0}) order by person.id) ssormlite1\r where rownum <= 0 + 1) ssormlite2 where ssormlite2.rnum > 0".Fmt(p))  //Oracle
                     );