Change SetParams to execute SqlExpression params before cloning them

Author: mythz

src/ServiceStack.OrmLite/Expressions/SqlExpression.cs

@@ -1789,14 +1789,12 @@ public static IDbDataParameter CreateParam(this IDbConnection db,
         {
             var dialectProvider = db.GetDialectProvider();
 
-            var to = new OrmLiteDataParameter
-            {
-                ParameterName = dialectProvider.GetParam(name),
-                Value = value,
-            };
+            var to = dialectProvider.CreateParam();
+
+            to.ParameterName = dialectProvider.GetParam(name);
+            to.Value = value;
 
             var valueType = value != null ? value.GetType() : typeof(string);
-            to.IsNullable = isNullable.GetValueOrDefault(value == null || !valueType.IsNullableType());
 
             if (precision != null)
                 to.Precision = precision.Value;

src/ServiceStack.OrmLite/OrmLiteResultsFilterExtensions.cs

@@ -139,13 +139,27 @@ internal static IDbCommand SetParameters(this IDbCommand dbCmd, IEnumerable<IDbD
             if (sqlParams == null) 
                 return dbCmd;
 
-            dbCmd.Parameters.Clear();
-
-            foreach (var sqlParam in sqlParams)
+            try
+            {
+                dbCmd.Parameters.Clear();
+                foreach (var sqlParam in sqlParams)
+                {
+                    dbCmd.Parameters.Add(sqlParam);
+                }
+            }
+            catch (Exception ex)
             {
-                var p = dbCmd.CreateParameter();
-                p.PopulateWith(sqlParam);
-                dbCmd.Parameters.Add(p);
+                //SQL Server + PostgreSql doesn't allow re-using db params in multiple queries
+                if (Log.IsDebugEnabled)
+                    Log.Debug("Exception trying to reuse db params, executing with cloned params instead", ex);
+
+                dbCmd.Parameters.Clear();
+                foreach (var sqlParam in sqlParams)
+                {
+                    var p = dbCmd.CreateParameter();
+                    p.PopulateWith(sqlParam);
+                    dbCmd.Parameters.Add(p);
+                }
             }
 
             return dbCmd;