code clean up

Author: mythz

src/ServiceStack.OrmLite.MySql/MySqlDialectProviderBase.cs

@@ -356,7 +356,8 @@ public override string GetQuotedValue(string paramValue)
 
         public override string GetQuotedValue(object value, Type fieldType)
         {
-            if (value == null) return "NULL";
+            if (value == null) 
+	            return "NULL";
 
             if (fieldType == typeof(byte[]))
                 return "0x" + BitConverter.ToString((byte[])value).Replace("-", "");

src/ServiceStack.OrmLite.VistaDB/VistaDbDialectProvider.cs

@@ -266,7 +266,7 @@ public override string ToExistStatement(Type fromTableType, object objWithProper
                 sql.Append(sqlFilter);
             }
 
-            return string.Format("SELECT EXISTS({0});", StringBuilderCache.ReturnAndFree(sql));
+            return $"SELECT EXISTS({StringBuilderCache.ReturnAndFree(sql)});";
         }
 
         public override string GetQuotedValue(object value, Type fieldType)
@@ -275,7 +275,7 @@ public override string GetQuotedValue(object value, Type fieldType)
                 return "NULL";
 
             if (fieldType == typeof(Guid))
-                return string.Format("CAST('{0}' AS UNIQUEIDENTIFIER)", (Guid)value);
+                return $"CAST('{(Guid) value}' AS UNIQUEIDENTIFIER)";
 
             return base.GetQuotedValue(value, fieldType);
         }

src/ServiceStack.OrmLite/OrmLiteDialectProviderBase.cs

@@ -1584,7 +1584,8 @@ protected virtual string FkOptionToString(OnFkOption option)
 
         public virtual string GetQuotedValue(object value, Type fieldType)
         {
-            if (value == null) return "NULL";
+            if (value == null) 
+                return "NULL";
 
             var converter = value.GetType().IsEnum
                 ? EnumConverter

src/ServiceStack.OrmLite/OrmLiteUtils.cs

@@ -544,7 +544,10 @@ public static string StripQuotedStrings(this string text, char quote = '\'')
 
         public static string SqlJoin<T>(this List<T> values, IOrmLiteDialectProvider dialect = null)
         {
-            dialect = dialect ?? OrmLiteConfig.DialectProvider;
+            if (values == null)
+                return string.Empty;
+
+            dialect ??= OrmLiteConfig.DialectProvider;
 
             var sb = StringBuilderCache.Allocate();
             foreach (var value in values)
@@ -558,12 +561,16 @@ public static string SqlJoin<T>(this List<T> values, IOrmLiteDialectProvider dia
 
         public static string SqlJoin(IEnumerable values, IOrmLiteDialectProvider dialect = null)
         {
-            dialect = (dialect ?? OrmLiteConfig.DialectProvider);
+            if (values == null)
+                return string.Empty;
+            
+            dialect ??= OrmLiteConfig.DialectProvider;
 
             var sb = StringBuilderCache.Allocate();
             foreach (var value in values)
             {
-                if (sb.Length > 0) sb.Append(",");
+                if (sb.Length > 0) 
+                    sb.Append(",");
                 sb.Append(dialect.GetQuotedValue(value, value.GetType()));
             }
 

tests/ServiceStack.OrmLite.Tests/SqlDialectTests.cs renamed to tests/ServiceStack.OrmLite.Tests/SqlServerDialectTests.cs

@@ -14,9 +14,9 @@ public class Sqltest
     }
 
     [TestFixtureOrmLiteDialects(Dialect.AnySqlServer)]
-    public class SqlDialectTests : OrmLiteProvidersTestBase
+    public class SqlServerDialectTests : OrmLiteProvidersTestBase
     {
-        public SqlDialectTests(DialectContext context) : base(context) {}
+        public SqlServerDialectTests(DialectContext context) : base(context) {}
 
         [Test]
         public void Does_concat_values()