Merge duplicate populating params code, remove manual copy since using native Data params

Author: mythz

src/ServiceStack.OrmLite/Expressions/SqlExpression.cs

@@ -1588,7 +1588,7 @@ protected string ConvertInExpressionToSql(MethodCallExpression m, object quotedC
                     var newName = DialectProvider.GetParam(Params.Count.ToString());
                     if (oldName != newName)
                     {
-                        var pClone = p.Populate(DialectProvider.CreateParam());
+                        var pClone = DialectProvider.CreateParam().PopulateWith(p);
                         subSelect = subSelect.Replace(oldName, newName);
                         pClone.ParameterName = newName;
                         Params.Add(pClone);
@@ -1812,19 +1812,6 @@ public static IDbDataParameter CreateParam(this IDbConnection db,
 
             return to;
         }
-
-        public static IDbDataParameter Populate(this IDbDataParameter p, IDbDataParameter to)
-        {
-            to.DbType = p.DbType;
-            to.ParameterName = p.ParameterName;
-            to.Value = p.Value;
-            to.Direction = p.Direction;
-            to.Precision = p.Precision;
-            to.Scale = p.Scale;
-            to.Size = p.Size;
-
-            return to;
-        }
     }
 }
 

src/ServiceStack.OrmLite/OrmLiteWriteCommandExtensions.cs

@@ -220,17 +220,7 @@ internal static int ExecuteSql(this IDbCommand dbCmd, string sql, IEnumerable<ID
         {
             dbCmd.CommandText = sql;
 
-            if (sqlParams != null)
-            {
-                dbCmd.Parameters.Clear();
-
-                foreach (var sqlParam in sqlParams)
-                {
-                    var p = dbCmd.CreateParameter();
-                    p.PopulateWith(sqlParam);
-                    dbCmd.Parameters.Add(p);
-                }
-            }
+            dbCmd.SetParameters(sqlParams);
 
             if (Log.IsDebugEnabled)
                 Log.DebugCommand(dbCmd);