Change Load APIs include to include .GetFieldNames() expression to maintain consistent features

Author: mythz

src/ServiceStack.OrmLite/OrmLiteReadApi.cs

@@ -597,9 +597,9 @@ public static T LoadSingleById<T>(this IDbConnection dbConn, object idValue, str
         /// Returns the first result with all its references loaded, using a primary key id. E.g:
         /// <para>db.LoadSingleById&lt;Person&gt;(1, include = x => new{ x.Address })</para>
         /// </summary>
-        public static T LoadSingleById<T>(this IDbConnection dbConn, object idValue, Func<T,object> include)
+        public static T LoadSingleById<T>(this IDbConnection dbConn, object idValue, Expression<Func<T, object>> include)
         {
-            return dbConn.Exec(dbCmd => dbCmd.LoadSingleById<T>(idValue, include(typeof(T).CreateInstance<T>()).GetType().AllAnonFields() ));
+            return dbConn.Exec(dbCmd => dbCmd.LoadSingleById<T>(idValue, include.GetFieldNames() ));
         }
 
         /// <summary>

src/ServiceStack.OrmLite/OrmLiteReadApiAsync.cs

@@ -524,11 +524,11 @@ public static Task<T> LoadSingleByIdAsync<T>(this IDbConnection dbConn, object i
 
         /// <summary>
         /// Returns the first result with all its references loaded, using a primary key id. E.g:
-        /// <para>db.LoadSingleById&lt;Person&gt;(1, include = x => new{ x.Address })</para>
+        /// <para>db.LoadSingleById&lt;Person&gt;(1, include = x => new { x.Address })</para>
         /// </summary>
-        public static Task<T> LoadSingleByIdAsync<T>(this IDbConnection dbConn, object idValue, Func<T, object> include, CancellationToken token = default(CancellationToken))
+        public static Task<T> LoadSingleByIdAsync<T>(this IDbConnection dbConn, object idValue, Expression<Func<T, object>> include, CancellationToken token = default(CancellationToken))
         {
-            return dbConn.Exec(dbCmd => dbCmd.LoadSingleByIdAsync<T>(idValue, include(typeof(T).CreateInstance<T>()).GetType().AllAnonFields(), token));
+            return dbConn.Exec(dbCmd => dbCmd.LoadSingleByIdAsync<T>(idValue, include.GetFieldNames(), token));
         }
 
         /// <summary>

src/ServiceStack.OrmLite/OrmLiteReadExpressionsApi.cs

@@ -256,9 +256,9 @@ public static List<T> LoadSelect<T>(this IDbConnection dbConn, Expression<Func<T
         /// Returns results with references from using a LINQ Expression. E.g:
         /// <para>db.LoadSelect&lt;Person&gt;(x =&gt; x.Age &gt; 40, include: x => new { x.PrimaryAddress })</para>
         /// </summary>
-        public static List<T> LoadSelect<T>(this IDbConnection dbConn, Expression<Func<T, bool>> predicate, Func<T, object> include)
+        public static List<T> LoadSelect<T>(this IDbConnection dbConn, Expression<Func<T, bool>> predicate, Expression<Func<T, object>> include)
         {
-            return dbConn.Exec(dbCmd => dbCmd.LoadSelect(predicate, include(typeof(T).CreateInstance<T>()).GetType().AllAnonFields()));
+            return dbConn.Exec(dbCmd => dbCmd.LoadSelect(predicate, include.GetFieldNames()));
         }
 
         /// <summary>
@@ -274,9 +274,9 @@ public static List<T> LoadSelect<T>(this IDbConnection dbConn, SqlExpression<T>
         /// Returns results with references from using an SqlExpression lambda. E.g:
         /// <para>db.LoadSelect(db.From&lt;Person&gt;().Where(x =&gt; x.Age &gt; 40), include: x => new { x.PrimaryAddress })</para>
         /// </summary>
-        public static List<T> LoadSelect<T>(this IDbConnection dbConn, SqlExpression<T> expression, Func<T, object> include)
+        public static List<T> LoadSelect<T>(this IDbConnection dbConn, SqlExpression<T> expression, Expression<Func<T, object>> include)
         {
-            return dbConn.Exec(dbCmd => dbCmd.LoadSelect(expression, include(typeof(T).CreateInstance<T>()).GetType().AllAnonFields()));
+            return dbConn.Exec(dbCmd => dbCmd.LoadSelect(expression, include.GetFieldNames()));
         }
 
         /// <summary>
@@ -290,9 +290,9 @@ public static List<Into> LoadSelect<Into, From>(this IDbConnection dbConn, SqlEx
         /// <summary>
         /// Project results with references from a number of joined tables into a different model
         /// </summary>
-        public static List<Into> LoadSelect<Into, From>(this IDbConnection dbConn, SqlExpression<From> expression, Func<Into, object> include)
+        public static List<Into> LoadSelect<Into, From>(this IDbConnection dbConn, SqlExpression<From> expression, Expression<Func<Into, object>> include)
         {
-            return dbConn.Exec(dbCmd => dbCmd.LoadSelect<Into, From>(expression, include(typeof(Into).CreateInstance<Into>()).GetType().AllAnonFields()));
+            return dbConn.Exec(dbCmd => dbCmd.LoadSelect<Into, From>(expression, include.GetFieldNames()));
         }
     }
 }