Skip to content
This repository was archived by the owner on Dec 24, 2022. It is now read-only.

Commit 83ce0e7

Browse files
labilbemythz
authored andcommitted
Fix Guid.Empty instead of new Guid() (#632)
new Guid() generates a pre-filled Guid. Guid.Empty returns an empty Guid (full of zeros).
1 parent 2bd836e commit 83ce0e7

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

tests/ServiceStack.OrmLite.Tests/AutoIdTests.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ public void Does_populate_and_return_new_guid_on_insert()
3232
db.Insert(guidA);
3333
db.Insert(guidB);
3434

35-
Assert.That(guidA.Id, Is.Not.EqualTo(new Guid()));
36-
Assert.That(guidB.Id, Is.Not.EqualTo(new Guid()));
35+
Assert.That(guidA.Id, Is.Not.EqualTo(Guid.Empty));
36+
Assert.That(guidB.Id, Is.Not.EqualTo(Guid.Empty));
3737
Assert.That(guidA.Id, Is.Not.EqualTo(guidB));
3838

3939
var dbA = db.SingleById<GuidAutoId>(guidA.Id);
@@ -57,8 +57,8 @@ public async Task Does_populate_and_return_new_guid_on_insert_Async()
5757
await db.InsertAsync(guidA);
5858
await db.InsertAsync(guidB);
5959

60-
Assert.That(guidA.Id, Is.Not.EqualTo(new Guid()));
61-
Assert.That(guidB.Id, Is.Not.EqualTo(new Guid()));
60+
Assert.That(guidA.Id, Is.Not.EqualTo(Guid.Empty));
61+
Assert.That(guidB.Id, Is.Not.EqualTo(Guid.Empty));
6262
Assert.That(guidA.Id, Is.Not.EqualTo(guidB));
6363

6464
var dbA = await db.SingleByIdAsync<GuidAutoId>(guidA.Id);
@@ -82,8 +82,8 @@ public void Does_populate_and_return_new_guid_on_save()
8282
db.Save(guidA);
8383
db.Save(guidB);
8484

85-
Assert.That(guidA.Id, Is.Not.EqualTo(new Guid()));
86-
Assert.That(guidB.Id, Is.Not.EqualTo(new Guid()));
85+
Assert.That(guidA.Id, Is.Not.EqualTo(Guid.Empty));
86+
Assert.That(guidB.Id, Is.Not.EqualTo(Guid.Empty));
8787
Assert.That(guidA.Id, Is.Not.EqualTo(guidB));
8888

8989
var dbA = db.SingleById<GuidAutoId>(guidA.Id);
@@ -107,8 +107,8 @@ public async Task Does_populate_and_return_new_guid_on_save_Async()
107107
await db.SaveAsync(guidA);
108108
await db.SaveAsync(guidB);
109109

110-
Assert.That(guidA.Id, Is.Not.EqualTo(new Guid()));
111-
Assert.That(guidB.Id, Is.Not.EqualTo(new Guid()));
110+
Assert.That(guidA.Id, Is.Not.EqualTo(Guid.Empty));
111+
Assert.That(guidB.Id, Is.Not.EqualTo(Guid.Empty));
112112
Assert.That(guidA.Id, Is.Not.EqualTo(guidB));
113113

114114
var dbA = await db.SingleByIdAsync<GuidAutoId>(guidA.Id);
@@ -161,4 +161,4 @@ public void Uses_existing_Guid_Id_if_not_Empty_for_row_inserts()
161161
}
162162
}
163163

164-
}
164+
}

0 commit comments

Comments
 (0)