rethrow exceptions in InsertAllAsync/UpdateAllAsync API's

Author: mythz

src/ServiceStack.OrmLite/Async/OrmLiteWriteCommandExtensionsAsync.cs

@@ -99,6 +99,9 @@ internal static Task<int> UpdateAllAsync<T>(this IDbCommand dbCmd, IEnumerable<T
                 if (dbTrans != null)
                     dbTrans.Dispose();
 
+                if (t.IsFaulted)
+                    throw t.Exception;
+
                 return count;
             });
         }
@@ -291,6 +294,9 @@ internal static Task InsertAllAsync<T>(this IDbCommand dbCmd, IEnumerable<T> obj
 
                 if (dbTrans != null)
                     dbTrans.Dispose();
+
+                if (t.IsFaulted)
+                    throw t.Exception;
             });
         }
 

tests/ServiceStack.OrmLiteV45.Tests/AsyncTests.cs

@@ -1,7 +1,9 @@
-using System.Threading;
+using System;
+using System.Threading;
 using System.Threading.Tasks;
 using NUnit.Framework;
 using ServiceStack.Common.Tests.Models;
+using ServiceStack.DataAnnotations;
 using ServiceStack.Text;
 
 using ServiceStack.OrmLite.Tests.Shared;
@@ -35,6 +37,70 @@ public async Task Can_Insert_and_SelectAsync()
             }
         }
 
+        [Test]
+        public async Task Does_throw_async_errors()
+        {
+            using (var db = OpenDbConnection())
+            {
+                db.DropAndCreateTable<Poco>();
+
+                try
+                {
+                    var results = await db.SelectAsync<Poco>(q => q.Where("NotExists = 1"));
+                    Assert.Fail("Should throw");
+                }
+                catch (Exception ex)
+                {
+                    Assert.That(ex.Message, Is.StringContaining("Id").Or.StringContaining("NotExists"));
+                }
+
+                try
+                {
+                    await db.InsertAsync(new DifferentPoco { NotExists = "Foo" });
+                    Assert.Fail("Should throw");
+                }
+                catch (Exception ex)
+                {
+                    Assert.That(ex.Message, Is.StringContaining("Id").Or.StringContaining("NotExists"));
+                }
+
+                try
+                {
+                    await db.InsertAllAsync(new[] {
+                        new DifferentPoco { NotExists = "Foo" },
+                        new DifferentPoco { NotExists = "Bar" }
+                    });
+                    Assert.Fail("Should throw");
+                }
+                catch (Exception ex)
+                {
+                    var innerEx = ex.UnwrapIfSingleException();
+                    Assert.That(innerEx.Message, Is.StringContaining("Id").Or.StringContaining("NotExists"));
+                }
+
+                try
+                {
+                    await db.UpdateAllAsync(new[] {
+                        new DifferentPoco { NotExists = "Foo" },
+                        new DifferentPoco { NotExists = "Bar" }
+                    });
+                    Assert.Fail("Should throw");
+                }
+                catch (Exception ex)
+                {
+                    var innerEx = ex.UnwrapIfSingleException();
+                    Assert.That(innerEx.Message, Is.StringContaining("Id").Or.StringContaining("NotExists"));
+                }
+            }
+        }
+
+        [Alias("Poco")]
+        public class DifferentPoco
+        {
+            public int Id { get; set; }
+            public string NotExists { get; set; }
+        }
+
         [Test]
         public async Task Test_Thread_Affinity()
         {