Skip to content
This repository was archived by the owner on Dec 24, 2022. It is now read-only.

Commit 8d328f4

Browse files
committed
Clear OrderBy in LoadList subselect
1 parent e33aad4 commit 8d328f4

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

src/ServiceStack.OrmLite/Support/LoadList.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ protected LoadList(IDbCommand dbCmd, SqlExpression<From> expr)
4545
modelDef = ModelDefinition<Into>.Definition;
4646
fieldDefs = modelDef.AllFieldDefinitionsArray.Where(x => x.IsReference).ToList();
4747

48-
expr.Select(dialectProvider.GetQuotedColumnName(modelDef, modelDef.PrimaryKey));
48+
expr.Select(dialectProvider.GetQuotedColumnName(modelDef, modelDef.PrimaryKey))
49+
.OrderBy(""); //Invalid in Sub Selects
4950
subSql = expr.ToSelectStatement();
5051
}
5152

tests/ServiceStack.OrmLite.Tests/LoadReferencesJoinTests.cs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -588,6 +588,20 @@ public void Can_join_on_references_attribute()
588588
row3 = db.LoadSingleById<TABLE_3>(row3.Id);
589589
Assert.That(row3.TableTwoKey, Is.EqualTo(row3.TableTwo.Id));
590590
}
591+
592+
[Test]
593+
public void Can_load_references_with_OrderBy()
594+
{
595+
AddCustomersWithOrders();
596+
597+
var customers = db.LoadSelect<Customer>(q => q.OrderBy(x => x.Name));
598+
var addresses = customers.Select(x => x.PrimaryAddress).ToList();
599+
var orders = customers.SelectMany(x => x.Orders).ToList();
600+
601+
Assert.That(customers.Count, Is.EqualTo(2));
602+
Assert.That(addresses.Count, Is.EqualTo(2));
603+
Assert.That(orders.Count, Is.EqualTo(6));
604+
}
591605
}
592606

593607
[Alias("Table1")]

0 commit comments

Comments
 (0)