More on FireBird4. (#629)

* Added support for FireBird 4.
Fixed DoesTableExist() that was returning null if table didn't exist.
Added support for the new FireBird 4 Identity autoincrement columns.
Added some tests for the new FirdBird 4 features.
Changed behavior of AutoIncrement fields to use Identity instead of Sequences when using the new FireBird 4 dialect.
Work in progress,,,,

* Fixed PopulateReturnValues() when  the primary key is a Guid (attribute AutoId). It tried to convert the value to an Int64.
Fixed PrepareParameterizedInsertStatement() in Firebird4OrmLiteDialectProvider to generate the insert sql with GEN_UUID() for the fields with AutoId attribute when using the FirebirdCompactGuidConverter.
Fixed ShouldSkipInsert() in FirebirdOrmLiteDialectProvider to not skip fields with AutoId attribute.
Added some tests for models with AutId attributes.

* Updated reserved words in FireBird4 dialect provider.
Changed the autoincrement definition from "by default" to "always" since there is no easy way to generate the insert sql based on object values. To use "By Default" the generated insert sql should not contain the Id field name if the Id value is null.
Updated FirebirdClient package to 6.6.0.
Changed obsolete method SelectFmt in Schema.cs.

Author: madaleno

src/ServiceStack.OrmLite.Firebird/FbSchema/Schema.cs

@@ -27,15 +27,15 @@ public Schema()
 			Init();
 		}
 
-		public List<Table> Tables => Connection.SelectFmt<Table>(sqlTables);
+		public List<Table> Tables => Connection.Select<Table>(sqlTables);
 
 		public Table GetTable(string name)
 		{
 
 			string sql = sqlTables +
 			             $"    AND a.rdb$relation_name ='{name}' ";
 
-            var query = Connection.SelectFmt<Table>(sql);
+            var query = Connection.Select<Table>(sql);
             return query.FirstOrDefault();
         }
 
@@ -46,14 +46,14 @@ public List<Column> GetColumns(string tableName)
 									   string.IsNullOrEmpty(tableName) ? "idx.rdb$relation_name" : $"'{tableName}'",
 									   string.IsNullOrEmpty(tableName) ? "r.rdb$relation_name" : $"'{tableName}'");
 
-            List<Column> columns =Connection.SelectFmt<Column>(sql);
+            List<Column> columns =Connection.Select<Column>(sql);
 
-            List<Generador> gens = Connection.SelectFmt<Generador>(sqlGenerator.ToString());
+            List<Generador> gens = Connection.Select<Generador>(sqlGenerator.ToString());
 
             sql = string.Format(sqlFieldGenerator.ToString(),
                                 string.IsNullOrEmpty(tableName) ? "TRIGGERS.RDB$RELATION_NAME" : $"'{tableName}'");
 
-            List<FieldGenerator> fg = Connection.SelectFmt<FieldGenerator>(sql);
+            List<FieldGenerator> fg = Connection.Select<FieldGenerator>(sql);
 
             foreach (var record in columns)
             {
@@ -87,11 +87,11 @@ public Procedure GetProcedure(string name)
 			string sql= sqlProcedures.ToString() +
 			            $"WHERE  b.rdb$procedure_name ='{name}'";
 
-            var query = Connection.SelectFmt<Procedure>(sql);
+            var query = Connection.Select<Procedure>(sql);
             return query.FirstOrDefault();
         }
 
-		public List<Procedure> Procedures => Connection.SelectFmt<Procedure>(sqlProcedures.ToString());
+		public List<Procedure> Procedures => Connection.Select<Procedure>(sqlProcedures.ToString());
 
 		public List<Parameter> GetParameters(Procedure procedure)
 		{
@@ -104,7 +104,7 @@ public List<Parameter> GetParameters(string procedureName)
 			string sql = string.Format(sqlParameters.ToString(),
 									   string.IsNullOrEmpty(procedureName) ? "a.rdb$procedure_name" : $"'{procedureName}'");
 
-            return Connection.SelectFmt<Parameter>(sql);
+            return Connection.Select<Parameter>(sql);
         }
 
 		private void Init()

src/ServiceStack.OrmLite.Firebird/Firebird4OrmLiteDialectProvider.cs

@@ -16,9 +16,26 @@ public class Firebird4OrmLiteDialectProvider : FirebirdOrmLiteDialectProvider
     {
         private readonly bool usesCompactGuid;
 
-        public static List<string> RESERVED = new List<string>(new[] {
-            "USER","ORDER","PASSWORD", "ACTIVE","LEFT","DOUBLE", "FLOAT", "DECIMAL","STRING", "DATE","DATETIME", "TYPE","TIMESTAMP",
-            "INDEX","UNIQUE", "PRIMARY", "KEY", "ALTER", "DROP", "CREATE", "DELETE", "VALUES", "FUNCTION", "INT", "LONG", "CHAR", "VALUE", "TIME"
+        public new static List<string> RESERVED = new List<string>(new[] {
+            "ADD","ADMIN","ALL","ALTER","AND","ANY","AS","AT","AVG","BEGIN","BETWEEN","BIGINT","BIT_LENGTH","BLOB","BOTH","BY","CASE","CAST",
+            "CHAR","CHAR_LENGTH","CHARACTER","CHARACTER_LENGTH","CHECK","CLOSE","COLLATE","COLUMN","COMMIT","CONNECT","CONSTRAINT","COUNT","CREATE",
+            "CROSS","CURRENT","CURRENT_CONNECTION","CURRENT_DATE","CURRENT_ROLE","CURRENT_TIME","CURRENT_TIMESTAMP","CURRENT_TRANSACTION","CURRENT_USER",
+            "CURSOR","DATE","DAY","DEC","DECIMAL","DECLARE","DEFAULT","DELETE","DISCONNECT","DISTINCT","DOUBLE","DROP","ELSE","END","ESCAPE",
+            "EXECUTE","EXISTS","EXTERNAL","EXTRACT","FETCH","FILTER","FLOAT","FOR","FOREIGN","FROM","FULL","FUNCTION","GDSCODE","GLOBAL","GRANT","GROUP",
+            "HAVING","HOUR","IN","INDEX","INNER","INSENSITIVE","INSERT","INT","INTEGER","INTO","IS","JOIN","LEADING","LEFT","LIKE","LONG","LOWER","MAX",
+            "MAXIMUM_SEGMENT","MERGE","MIN","MINUTE","MONTH","NATIONAL","NATURAL","NCHAR","NO","NOT","NULL","NUMERIC","OCTET_LENGTH","OF","ON","ONLY",
+            "OPEN","OR","ORDER","OUTER","PARAMETER","PLAN","POSITION","POST_EVENT","PRECISION","PRIMARY","PROCEDURE","RDB$DB_KEY","REAL","RECORD_VERSION",
+            "RECREATE","RECURSIVE","REFERENCES","RELEASE","RETURNING_VALUES","RETURNS","REVOKE","RIGHT","ROLLBACK","ROW_COUNT","ROWS","SAVEPOINT","SECOND",
+            "SELECT","SENSITIVE","SET","SIMILAR","SMALLINT","SOME","SQLCODE","SQLSTATE","START","SUM","TABLE","THEN","TIME","TIMESTAMP","TO","TRAILING",
+            "TRIGGER","TRIM","UNION","UNIQUE","UPDATE","UPPER","USER","USING","VALUE","VALUES","VARCHAR","VARIABLE","VARYING","VIEW","WHEN","WHERE","WHILE",
+            "WITH","YEAR",
+            "PASSWORD","ACTIVE","LEFT","DATETIME","TYPE","KEY",
+            // new in FB3
+            "INSERTING","UPDATING","DELETING","REGR_AVGX","SCROLL","CORR","REGR_AVGY","COVAR_POP","REGR_COUNT","STDDEV_POP",
+            "COVAR_SAMP","REGR_INTERCEPT","STDDEV_SAMP","REGR_R2","TRUE","DETERMINISTIC","REGR_SLOPE","UNKNOWN","FALSE","REGR_SXX",
+            "REGR_SXY","VAR_POP","OFFSET","REGR_SYY","VAR_SAMP","OVER","RETURN","RDB$RECORD_VERSION","ROW","BOOLEAN",
+            // new in FB4
+            "BINARY","VARBINARY","DECFLOAT"
         });
 
         public new static Firebird4OrmLiteDialectProvider Instance = new Firebird4OrmLiteDialectProvider();
@@ -30,7 +47,7 @@ public Firebird4OrmLiteDialectProvider(bool compactGuid): base(compactGuid)
             usesCompactGuid = compactGuid;
 
             // FB4 now has identity columns
-            base.AutoIncrementDefinition = " GENERATED BY DEFAULT AS IDENTITY ";
+            base.AutoIncrementDefinition = " GENERATED ALWAYS AS IDENTITY ";
             NamingStrategy = new Firebird4NamingStrategy();
 
             base.RemoveConverter<bool>();

src/ServiceStack.OrmLite.Firebird/ServiceStack.OrmLite.Firebird.Core.csproj

@@ -16,7 +16,7 @@
   <ItemGroup>
     <ProjectReference Include="..\ServiceStack.OrmLite\ServiceStack.OrmLite.Core.csproj" />
     <PackageReference Include="ServiceStack.Common.Core" Version="$(Version)" />
-    <PackageReference Include="FirebirdSql.Data.FirebirdClient" Version="6.5.0" />
+    <PackageReference Include="FirebirdSql.Data.FirebirdClient" Version="6.6.0" />
   </ItemGroup>
 
 </Project>