clean up methods

Author: mythz

src/ServiceStack.OrmLite/OrmLiteReadExtensions.cs

@@ -549,8 +549,7 @@ public static List<T> GetByIds<T>(this IDbCommand dbCmd, IEnumerable idValues)
 				: Select<T>(dbCmd, OrmLiteConfig.DialectProvider.GetQuotedColumnName(ModelDefinition<T>.PrimaryKeyName) + " IN (" + sql + ")");
 		}
 
-        [Obsolete(UseDbConnectionExtensions)]
-        public static T GetByIdParam<T>(this IDbCommand dbCmd, object id)
+	    internal static T GetByIdParam<T>(this IDbCommand dbCmd, object id)
             where T : new()
         {
             var modelDef = ModelDefinition<T>.Definition;

src/ServiceStack.OrmLite/OrmLiteWriteConnectionExtensions.cs

@@ -115,8 +115,6 @@ public static void UpdateParam<T>(this IDbConnection dbConn, T obj)
         {
             dbConn.Exec(dbCmd =>
             {
-                //var updateStmt = dbCmd.ReparameterizeInsert(obj)
-
                 var updateStmt = dbConn.CreateUpdateStatement(obj);
 
                 dbCmd.CommandText = updateStmt.CommandText;

src/ServiceStack.OrmLite/OrmLiteWriteExtensions.cs

@@ -290,8 +290,7 @@ public static void UpdateAll<T>(this IDbCommand dbCmd, IEnumerable<T> objs)
 			}
 		}
 
-        [Obsolete(UseDbConnectionExtensions)]
-        public static IDbCommand CreateUpdateStatement<T>(this IDbConnection connection, T obj)
+        internal static IDbCommand CreateUpdateStatement<T>(this IDbConnection connection, T obj)
             where T : new()
         {
             return OrmLiteConfig.DialectProvider.CreateParameterizedUpdateStatement(obj, connection);
@@ -430,20 +429,12 @@ public static void InsertAll<T>(this IDbCommand dbCmd, IEnumerable<T> objs)
 			}
 		}
 
-        [Obsolete(UseDbConnectionExtensions)]
-        public static IDbCommand CreateInsertStatement<T>(this IDbConnection connection, T obj)
+        internal static IDbCommand CreateInsertStatement<T>(this IDbConnection connection, T obj)
             where T: new()
         {
             return OrmLiteConfig.DialectProvider.CreateParameterizedInsertStatement(obj, connection);
         }
 
-        [Obsolete(UseDbConnectionExtensions)]
-        public static void ReparameterizeInsert<T>(this IDbCommand command, T obj)
-            where T : new()
-        {
-            OrmLiteConfig.DialectProvider.ReParameterizeInsertStatement(obj, command);
-        }
-
         [Obsolete(UseDbConnectionExtensions)]
         public static void Save<T>(this IDbCommand dbCmd, params T[] objs)
             where T : new()

tests/ServiceStack.OrmLite.Tests/SqlServerProviderTests.cs

@@ -143,6 +143,9 @@ SELECT @Times AS Id
 
             result = db.SqlScalar<int>("EXEC DummyScalar @Times", new Dictionary<string, object> { { "Times", 10 } });
             Assert.That(result, Is.EqualTo(expected));
+
+            result = db.SqlScalar<int>("SELECT 10");
+            Assert.That(result, Is.EqualTo(expected));
         }
 
     }