Throw OptimisticConcurrencyException in StrictMode + add subselect expr example

Author: mythz

src/ServiceStack.OrmLite/OrmLiteWriteCommandExtensions.cs

@@ -18,6 +18,7 @@
 using ServiceStack.DataAnnotations;
 using ServiceStack.Logging;
 using ServiceStack.OrmLite.Converters;
+using ServiceStack.Text;
 
 namespace ServiceStack.OrmLite
 {
@@ -872,7 +873,7 @@ internal static bool Save<T>(this IDbCommand dbCmd, T obj)
             }
 
             var rowsUpdated = dbCmd.Update(obj);
-            if (rowsUpdated == 0)
+            if (rowsUpdated == 0 && Env.StrictMode)
                 throw new OptimisticConcurrencyException("No rows were inserted or updated");
 
             modelDef.RowVersion?.SetValueFn(obj, dbCmd.GetRowVersion(modelDef, id, modelDef.RowVersion.ColumnType));

tests/ServiceStack.OrmLite.Tests/Expression/SqlExpressionTests.cs

@@ -653,5 +653,32 @@ public void Can_select_limit_on_Table_with_References()
                 Assert.That(results[0].Orders.Count, Is.EqualTo(2));
             }
         }
+
+        [Test]
+        public void Can_select_subselect()
+        {
+            using (var db = OpenDbConnection())
+            {
+                db.DropAndCreateTable<LetterFrequency>();
+
+                var insertedIds = "A,B,B,C,C,C,D,D,E".Split(',').Map(letter => 
+                    db.Insert(new LetterFrequency { Letter = letter }, selectIdentity: true));
+
+                var q = db.From<LetterFrequency>(db.TableAlias("x"));
+                q.Where(x => x.Letter == Sql.Custom(q.Column<LetterFrequency>(c => c.Letter, true)));
+                var subSql = q.Select(Sql.Count("*")).ToSelectStatement();
+                
+                var rows = db.Select<Dictionary<string, object>>(db.From<LetterFrequency>()
+                    .Where(x => x.Letter == "C")
+                    .Select(x => new {
+                        x,
+                        LetterCount = Sql.Custom($"({subSql})"),
+                    }));
+                
+//                rows.PrintDump();
+                Assert.That(rows.Count, Is.EqualTo(3));
+                Assert.That(rows.All(x => x["LetterCount"].ConvertTo<int>() == 3));
+            }
+        }
     }
 }