Move conversion to Enum Type into EnumConverter

Author: mythz

src/ServiceStack.OrmLite.MySql.Tests/EnumTests.cs

@@ -135,15 +135,15 @@ public void CanQueryByNullableEnumValue_using_where_with_AnonType()
         [Test]
         public void CanSaveNullableEnum_with_specific_id_select_with_anon_type()
         {
-            using (var con = OpenDbConnection())
+            using (var db = OpenDbConnection())
             {
-                con.CreateTableIfNotExists<MyObj>();
+                db.DropAndCreateTable<MyObj>();
                 var myObj = new MyObj();
                 myObj.Id = 1;
                 myObj.Test = MyEnum.One;
-                con.Insert(myObj);
+                db.Insert(myObj);
 
-                myObj = con.Single<MyObj>(new {Id = 1});
+                myObj = db.Single<MyObj>(new {Id = 1});
 
                 Assert.That(myObj.Id, Is.EqualTo(1));
                 Assert.That(myObj.Test, Is.Not.EqualTo(null));
@@ -154,13 +154,13 @@ public void CanSaveNullableEnum_with_specific_id_select_with_anon_type()
         [Test]
         public void CanSaveNullableEnum_with_specific_id_select_with_type()
         {
-            using (var existsCon = OpenDbConnection())
+            using (var db = OpenDbConnection())
             {
-                existsCon.CreateTableIfNotExists<MyObj>();
-                var exists = existsCon.SingleById<MyObj>(1);
+                db.DropAndCreateTable<MyObj>();
+                var exists = db.SingleById<MyObj>(1);
                 if (exists != null)
                 {
-                    existsCon.DeleteById<MyObj>(1);
+                    db.DeleteById<MyObj>(1);
                 }
             }
 

src/ServiceStack.OrmLite/Converters/SpecialConverters.cs

@@ -59,7 +59,7 @@ public override object FromDbValue(Type fieldType, object value)
             if (strVal != null)
                 return Enum.Parse(fieldType, strVal, ignoreCase:true);
 
-            return Convert.ChangeType(value, fieldType.GetTypeCode());
+            return Enum.ToObject(fieldType, value);
         }
     }
 

src/ServiceStack.OrmLite/OrmLiteWriteCommandExtensions.cs

@@ -341,16 +341,7 @@ public static T PopulateWithSqlReader<T>(this T objWithProperties,
                         else
                         {
                             var fieldValue = converter.FromDbValue(fieldDef.FieldType, value);
-                            if (fieldDef.FieldType.IsEnum && fieldDef.IsNullable)
-                            {
-                                var enumType = Nullable.GetUnderlyingType(fieldDef.PropertyInfo.PropertyType);
-                                var enumValue = Enum.ToObject(enumType, value);
-                                fieldDef.PropertyInfo.SetProperty(objWithProperties, enumValue);
-                            }
-                            else
-                            {
-                                fieldDef.SetValueFn(objWithProperties, fieldValue);
-                            }
+                            fieldDef.SetValueFn(objWithProperties, fieldValue);
                         }
                     }
                 }