Fix SQL Server 2012 tests

Author: mythz

src/ServiceStack.OrmLite.SqlServer/SqlServer2012OrmLiteDialectProvider.cs

@@ -171,6 +171,12 @@ public override string ToCreateTableStatement(Type tableType)
 
                     sbColumns.Append(columnDefinition);
 
+                    var sqlConstraint = GetCheckConstraint(fieldDef);
+                    if (sqlConstraint != null)
+                    {
+                        sbConstraints.Append(",\n" + sqlConstraint);
+                    }
+
                     if (fieldDef.ForeignKey == null || OrmLiteConfig.SkipForeignKeys)
                         continue;
 

tests/ServiceStack.OrmLite.Tests/CaptureSqlCommandFilterTests.cs

@@ -118,7 +118,7 @@ public void Can_capture_command_all_Single_Apis()
                 Assert.That(captured.SqlCommandHistory.Last().Sql.NormalizeSql(),
                     Is.EqualTo("select id, firstname, lastname, age  from person where (age = {0}) limit 1".Fmt(p)).  //Sqlite
                     Or.EqualTo("select top 1 id, firstname, lastname, age  from person where (age = {0})".Fmt(p)).    //SQLServer < 2012
-                    Or.EqualTo("select id, firstname, lastname, age  from person where (age = {0}) order by person.id offset 0 rows fetch next 1 rows only".Fmt(p)). //SQLServer >= 2012
+                    Or.EqualTo("select id, firstname, lastname, age  from person where (age = {0}) order by 1 offset 0 rows fetch next 1 rows only".Fmt(p)). //SQLServer >= 2012
                     Or.EqualTo("select first 1 id, firstname, lastname, age  from person where (age = {0})".Fmt(p))); //Firebird
 
                 i++; db.Exists<Person>("Age = @age", new { age = 42 });

tests/ServiceStack.OrmLite.Tests/CaptureSqlFilterTests.cs

@@ -118,6 +118,7 @@ public void Can_capture_all_Single_Apis()
                 Assert.That(captured.SqlStatements.Last().NormalizeSql(),
                     Is.EqualTo("select id, firstname, lastname, age  from person where (age = {0}) limit 1".Fmt(p)). //sqlite
                     Or.EqualTo("select top 1 id, firstname, lastname, age  from person where (age = {0})".Fmt(p)).   //SqlServer
+                    Or.EqualTo("select id, firstname, lastname, age  from person where (age = {0}) order by 1 offset 0 rows fetch next 1 rows only".Fmt(p)).   //SqlServer 2012+
                     Or.EqualTo("select first 1 id, firstname, lastname, age  from person where (age = {0})".Fmt(p)).  //Firebird
                     Or.EqualTo("select id, firstname, lastname, age  from person where (age = {0}) order by person.id offset 0 rows fetch next 1 rows only".Fmt(p)). //VistaDB
                     Or.EqualTo("select * from (\r select ssormlite1.*, rownum rnum from (\r select id, firstname, lastname, age  from person where (age = {0}) order by person.id) ssormlite1\r where rownum <= 0 + 1) ssormlite2 where ssormlite2.rnum > 0".Fmt(p))  //Oracle

tests/ServiceStack.OrmLite.Tests/DefaultValueTests.cs

@@ -110,7 +110,8 @@ public void Can_filter_update_method1_to_insert_date()
 
                 ResetUpdateDate(db);
                 db.Update(cmd => cmd.SetUpdateDate<DefaultValues>(nameof(DefaultValues.UpdatedDateUtc)),
-                    new DefaultValues { Id = 1, DefaultInt = 45 }, new DefaultValues { Id = 2, DefaultInt = 72 });
+                    new DefaultValues { Id = 1, DefaultInt = 45, CreatedDateUtc = DateTime.Now }, 
+                    new DefaultValues { Id = 2, DefaultInt = 72, CreatedDateUtc = DateTime.Now });
                 VerifyUpdateDate(db);
                 VerifyUpdateDate(db, id: 2);
             }
@@ -139,7 +140,7 @@ public void Can_filter_update_method2_to_insert_date()
                 CreateAndInitialize(db);
 
                 ResetUpdateDate(db);
-                db.Update(new DefaultValues { Id = 1, DefaultInt = 2342 }, p => p.Id == 1,
+                db.Update(new DefaultValues { Id = 1, DefaultInt = 2342, CreatedDateUtc = DateTime.Now }, p => p.Id == 1,
                     cmd => cmd.SetUpdateDate<DefaultValues>(nameof(DefaultValues.UpdatedDateUtc)));
                 VerifyUpdateDate(db);
             }
@@ -183,7 +184,8 @@ public void Can_filter_updateAll_to_insert_date()
                 CreateAndInitialize(db, 2);
 
                 ResetUpdateDate(db);
-                db.UpdateAll(new [] { new DefaultValues { Id = 1, DefaultInt = 45 }, new DefaultValues { Id = 2, DefaultInt = 72 } },
+                db.UpdateAll(new [] { new DefaultValues { Id = 1, DefaultInt = 45, CreatedDateUtc = DateTime.Now },
+                                      new DefaultValues { Id = 2, DefaultInt = 72, CreatedDateUtc = DateTime.Now } },
                     cmd => cmd.SetUpdateDate<DefaultValues>(nameof(DefaultValues.UpdatedDateUtc)));
                 VerifyUpdateDate(db);
                 VerifyUpdateDate(db, id: 2);

tests/ServiceStack.OrmLite.Tests/Expression/SqlCustomTests.cs

@@ -35,7 +35,7 @@ public class SqlCustomTests : OrmLiteTestBase
         [Test]
         public void Can_use_CustomSelect_field_in_Typed_Query()
         {
-            if (Dialect == Dialect.PostgreSql || Dialect == Dialect.SqlServer || Dialect == Dialect.MySql) return;
+            if (Dialect == Dialect.PostgreSql || Dialect == Dialect.SqlServer || Dialect == Dialect.SqlServer2012 || Dialect == Dialect.MySql) return;
 
             using (var db = OpenDbConnection())
             {

tests/ServiceStack.OrmLite.Tests/OrmLiteTestBase.cs

@@ -12,6 +12,7 @@ namespace ServiceStack.OrmLite.Tests
 {
     public class Config
     {
+        public const bool EnableDebugLogging = false;
         public static string SqliteMemoryDb = ":memory:";
         public static string SqliteFileDir = "~/App_Data/".MapAbsolutePath();
         public static string SqliteFileDb = "~/App_Data/db.sqlite".MapAbsolutePath();
@@ -124,7 +125,7 @@ private OrmLiteConnectionFactory Init()
             //OrmLiteConfig.UseParameterizeSqlExpressions = false;
 
             //OrmLiteConfig.DeoptimizeReader = true;
-            LogManager.LogFactory = new ConsoleLogFactory(debugEnabled: false);
+            LogManager.LogFactory = new ConsoleLogFactory(debugEnabled: Config.EnableDebugLogging);
             switch (Dialect)
             {
                 case Dialect.Sqlite: