Fix Sqlite IsolationLevel.ReadCommited on .NET Core

Author: xplicit

src/ServiceStack.OrmLite.Sqlite/NetCoreSqliteConnection.cs

@@ -0,0 +1,22 @@
+#if NETSTANDARD1_3
+using System.Data;
+using Microsoft.Data.Sqlite;
+
+namespace ServiceStack.OrmLite.Sqlite
+{
+    public class NetCoreSqliteConnection : SqliteConnection
+    {
+        public NetCoreSqliteConnection(string connectionString) 
+            : base(connectionString) {}
+
+        public override SqliteTransaction BeginTransaction(IsolationLevel isolationLevel)
+        {
+            //.NET Core Sqlite does not support IsolationLevel.ReadCommited
+            if (isolationLevel == IsolationLevel.ReadCommitted)
+                isolationLevel = IsolationLevel.Serializable;
+
+            return base.BeginTransaction(isolationLevel);
+        }
+    }
+}
+#endif

src/ServiceStack.OrmLite.Sqlite/ServiceStack.OrmLite.Sqlite.Android.csproj

@@ -59,6 +59,7 @@
     <Compile Include="SqliteOrmLiteDialectProvider.cs" />
     <Compile Include="SqliteOrmLiteDialectProviderBase.cs" />
     <Compile Include="SqliteExpression.cs" />
+    <Compile Include="NetCoreSqliteConnection.cs" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\ServiceStack.OrmLite\ServiceStack.OrmLite.Android.csproj">

src/ServiceStack.OrmLite.Sqlite/ServiceStack.OrmLite.Sqlite.csproj

@@ -120,6 +120,7 @@
     <Compile Include="SqliteOrmLiteDialectProvider.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="SqliteExpression.cs" />
+    <Compile Include="NetCoreSqliteConnection.cs" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\ServiceStack.OrmLite\ServiceStack.OrmLite.csproj">

src/ServiceStack.OrmLite.Sqlite/ServiceStack.OrmLite.Sqlite.iOS.csproj

@@ -39,6 +39,7 @@
     <Compile Include="SqliteExpressionVisitor.cs" />
     <Compile Include="SqliteOrmLiteDialectProvider.cs" />
     <Compile Include="SqliteOrmLiteDialectProviderBase.cs" />
+    <Compile Include="NetCoreSqliteConnection.cs" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\ServiceStack.OrmLite\ServiceStack.OrmLite.iOS.csproj">

src/ServiceStack.OrmLite.Sqlite/SqliteOrmLiteDialectProvider.cs

@@ -13,7 +13,11 @@ public class SqliteOrmLiteDialectProvider : SqliteOrmLiteDialectProviderBase
 
         protected override IDbConnection CreateConnection(string connectionString)
         {
+#if NETSTANDARD1_3
+            return new NetCoreSqliteConnection(connectionString);
+#else
             return new SqliteConnection(connectionString);
+#endif
         }
 
         public override IDbDataParameter CreateParam()

tests/ServiceStack.OrmLite.Tests/Issues/SaveDomainUserReferencesIssue.cs

@@ -83,13 +83,7 @@ public void Can_save_DomainUser_references()
                     }
                 };
 
-#if NETCORE
-                var isolationLevel = base.Dialect == Dialect.Sqlite ? IsolationLevel.Serializable : IsolationLevel.ReadCommitted;
-#else
-                var isolationLevel = IsolationLevel.ReadCommitted;
-#endif                
-
-                using (var trans = db.OpenTransaction(isolationLevel))
+                using (var trans = db.OpenTransaction(IsolationLevel.ReadCommitted))
                 {
                     //Same as below in 1 line
                     //db.Save(user, references: true);
@@ -113,7 +107,7 @@ public void Can_save_DomainUser_references()
                     Details = "Reese",
                 });
 
-                using (var trans = db.OpenTransaction(isolationLevel))
+                using (var trans = db.OpenTransaction(IsolationLevel.ReadCommitted))
                 {
                     //Same as below in 1 line
                     //db.Save(user, references: true);

tests/ServiceStack.OrmLite.Tests/ShippersExample.cs

@@ -81,13 +81,7 @@ public void Shippers_UseCase()
 					dbTrans.Commit();
 				}
 
-#if NETCORE
-                var isolationLevel = base.Dialect == Dialect.Sqlite ? IsolationLevel.Serializable : IsolationLevel.ReadCommitted;
-#else
-                var isolationLevel = IsolationLevel.ReadCommitted;
-#endif                
-
-				using (IDbTransaction dbTrans = db.OpenTransaction(isolationLevel))
+				using (IDbTransaction dbTrans = db.OpenTransaction(IsolationLevel.ReadCommitted))
 				{
 					db.Insert(new ShipperType { Name = "Automobiles" });
 					Assert.That(db.Select<ShipperType>(), Has.Count.EqualTo(3));

tests/ServiceStack.OrmLite.Tests/UseCase/CustomerOrdersUseCase.cs

@@ -169,14 +169,8 @@ public void Run()
                 customer = db.Single<Customer>(new { customer.Email }); //Query
                 Assert.That(customer.Id, Is.EqualTo(customerId));
 
-#if NETCORE
-                var isolationLevel = base.Dialect == Dialect.Sqlite ? IsolationLevel.Serializable : IsolationLevel.ReadCommitted;
-#else
-                var isolationLevel = IsolationLevel.ReadCommitted;
-#endif                
-
                 //Direct access to System.Data.Transactions:
-                using (IDbTransaction trans = db.OpenTransaction(isolationLevel))
+                using (IDbTransaction trans = db.OpenTransaction(IsolationLevel.ReadCommitted))
                 {
                     var order = new Order {
                         CustomerId = customer.Id,

tests/ServiceStack.OrmLite.Tests/UseCase/CustomerOrdersUseCaseAsync.cs

@@ -50,14 +50,8 @@ public async Task Can_run_Customer_Orders_UseCase()
                 customer = await db.SingleAsync<Customer>(new { customer.Email }); //Query
                 Assert.That(customer.Id, Is.EqualTo(customerId));
 
-#if NETCORE
-                var isolationLevel = base.Dialect == Dialect.Sqlite ? IsolationLevel.Serializable : IsolationLevel.ReadCommitted;
-#else
-                var isolationLevel = IsolationLevel.ReadCommitted;
-#endif                
-
                 //Direct access to System.Data.Transactions:
-                using (IDbTransaction trans = db.OpenTransaction(isolationLevel))
+                using (IDbTransaction trans = db.OpenTransaction(IsolationLevel.ReadCommitted))
                 {
                     var order = new Order {
                         CustomerId = customer.Id,