Refactor FirebirdSqlServerExpression to use DialectProvider

Author: mythz

src/ServiceStack.OrmLite.Firebird/FirebirdOrmLiteDialectProvider.cs

@@ -806,7 +806,48 @@ public override string ToChangeColumnNameStatement(Type modelType,
                                  GetQuotedColumnName(fieldDef.FieldName));
         }
         #endregion DDL
+
+        public override string ToSelectStatement(ModelDefinition modelDef,
+            string selectExpression,
+            string bodyExpression,
+            string orderByExpression = null,
+            int? offset = null,
+            int? rows = null)
+        {
+
+            var sb = new StringBuilder(selectExpression);
+            sb.Append(bodyExpression);
+            if (orderByExpression != null)
+            {
+                sb.Append(orderByExpression);
+            }
+
+            if (offset != null)
+            {
+                int fromRow = offset.Value + 1;
+                if (fromRow <= 0)
+                    throw new ArgumentException(
+                        string.Format("Skip value:'{0}' must be>=0", offset.Value));
+                string toRow;
+                if (rows.HasValue)
+                {
+                    if (rows.Value < 0)
+                    {
+                        throw new ArgumentException(string.Format("Rows value:'{0}' must be>=0", rows.Value));
+                    }
+                    toRow = string.Format("TO {0}", fromRow + rows.Value - 1);
+                }
+                else
+                {
+                    toRow = string.Empty;
+                }
+                sb.Append(string.Format("ROWS {0} {1}", fromRow, toRow));
+            }
+
+            return sb.ToString();
+        }
     }
+
 }
 
 /*

src/ServiceStack.OrmLite.Firebird/FirebirdSqlExpression.cs

@@ -160,34 +160,6 @@ private bool IsFalseExpression(object exp)
         {
             return (exp.ToString() == _falseExpression);
         }
-
-        public override string LimitExpression
-        {
-            get
-            {
-                if (!Offset.HasValue) return "";
-                int fromRow = Offset.Value + 1;
-                if (fromRow <= 0)
-                    throw new ArgumentException(
-                        string.Format("Skip value:'{0}' must be>=0", Offset.Value));
-                string toRow;
-                if (Rows.HasValue)
-                {
-                    if (Rows.Value < 0)
-                    {
-                        throw new ArgumentException(
-                            string.Format("Rows value:'{0}' must be>=0", Rows.Value));
-                    }
-                    toRow = string.Format("TO {0}", fromRow + Rows.Value - 1);
-                }
-                else
-                {
-                    toRow = string.Empty;
-                }
-                return string.Format("ROWS {0} {1}", fromRow, toRow);
-            }
-        }
-
     }
 }