Make bool sql expressions consistent with and without joined tables

Author: mythz

src/ServiceStack.OrmLite/Expressions/SqlExpression.cs

@@ -1185,12 +1185,11 @@ protected string RemoveQuoteFromAlias(string exp)
 
         protected bool IsFieldName(object quotedExp)
         {
-            FieldDefinition fd =
-                modelDef.FieldDefinitions.
-                    FirstOrDefault(x =>
-                        DialectProvider.
-                        GetQuotedColumnName(x.FieldName) == quotedExp.ToString());
-            return (fd != default(FieldDefinition));
+            var fieldExpr = quotedExp.ToString().StripTablePrefixes();
+            var fieldNames = modelDef.FieldDefinitions.Map(x =>
+                DialectProvider.GetQuotedColumnName(x.FieldName));
+
+            return fieldNames.Any(x => x == fieldExpr);
         }
 
         protected object GetTrueExpression()

tests/ServiceStack.OrmLite.Tests/Expression/SqlExpressionTests.cs

@@ -286,7 +286,8 @@ public void Can_OrderBy_Fields_with_different_sort_directions()
                 db.DropAndCreateTable<LetterStat>();
 
                 var insertedIds = new List<long>();
-                "A,B,B,C,C,C,D,D,E".Split(',').Each(letter => {
+                "A,B,B,C,C,C,D,D,E".Split(',').Each(letter =>
+                {
                     insertedIds.Add(db.Insert(new LetterFrequency { Letter = letter }, selectIdentity: true));
                 });
 
@@ -344,5 +345,54 @@ public void Can_select_limit_on_Table_with_References()
                 Assert.That(results[0].Orders.Count, Is.EqualTo(2));
             }
         }
+
+        public class TableA
+        {
+            public int Id { get; set; }
+            public bool Bool { get; set; }
+        }
+
+        public class TableB
+        {
+            public int Id { get; set; }
+            public int TableAId { get; set; }
+        }
+
+        [Test]
+        public void Can_query_bools()
+        {
+            using (var db = OpenDbConnection())
+            {
+                db.DropAndCreateTable<TableA>();
+                db.DropAndCreateTable<TableB>();
+
+                db.Insert(new TableA { Id = 1, Bool = false });
+                db.Insert(new TableB { Id = 1, TableAId = 1 });
+
+                var q = db.From<TableA>()
+                    .LeftJoin<TableB>((a, b) => a.Id == b.Id)
+                    .Where(a => !a.Bool);
+
+                var result = db.Single(q);
+                db.GetLastSql().Print();
+                Assert.That(result.Id, Is.EqualTo(1));
+
+                q = db.From<TableA>()
+                    .Where(a => !a.Bool)
+                    .LeftJoin<TableB>((a, b) => a.Id == b.Id);
+
+                result = db.Single(q);
+                db.GetLastSql().Print();
+                Assert.That(result.Id, Is.EqualTo(1));
+
+
+                q = db.From<TableA>()
+                    .Where(a => !a.Bool);
+
+                result = db.Single(q);
+                db.GetLastSql().Print();
+                Assert.That(result.Id, Is.EqualTo(1));
+            }
+        }
     }
 }