Fixed regression caused by last commit and fixed root issue.

1. Fixed previously existing issue in construction of Update command
where AppendFieldCondition was being called instead of Field =
Parameter. (line 767 in OrmLiteDialectProviderBase.cs)
2. Added a new virtual AppendNullFieldCondition method to
OrmLiteDialectProviderBase.cs to handle Spatial null conditions.
3. Added AppendFieldCondition and AppendNullFieldCondition overrides to
SqlServer2012OrmLiteDialectProvider.
4. Made dialect provider an optional parameter in the OpenDbConnection
method in the SqlServerTests.

Author: KevinHoward

src/ServiceStack.OrmLite.SqlServer/SqlServer2012OrmLiteDialectProvider.cs

@@ -1,4 +1,6 @@
-using ServiceStack.Text;
+using System.Data;
+using System.Text;
+using ServiceStack.Text;
 
 namespace ServiceStack.OrmLite.SqlServer
 {
@@ -39,5 +41,40 @@ public override string ToSelectStatement(ModelDefinition modelDef,
 
             return StringBuilderCache.ReturnAndFree(sb);
         }
+
+        public override void AppendFieldCondition(StringBuilder sqlFilter, FieldDefinition fieldDef, IDbCommand cmd)
+        {
+            if (!isSpatialField(fieldDef))
+            {
+                base.AppendFieldCondition(sqlFilter, fieldDef, cmd);
+            }
+            else 
+            {
+                sqlFilter
+                    .Append(GetQuotedColumnName(fieldDef.FieldName))
+                    .Append(".STEquals(")
+                    .Append(this.GetParam(SanitizeFieldNameForParamName(fieldDef.FieldName)))
+                    .Append(") = 1");
+ 
+                AddParameter(cmd, fieldDef);
+            }
+        }
+
+        public override void AppendNullFieldCondition(StringBuilder sqlFilter, FieldDefinition fieldDef)
+        {
+            if (!isSpatialField(fieldDef))
+            {
+                base.AppendNullFieldCondition(sqlFilter, fieldDef);
+            }
+            else
+            {
+                sqlFilter
+                    .Append(GetQuotedColumnName(fieldDef.FieldName))
+                    .Append(".IsNull = 1");
+            }
+        }
+
+        private bool isSpatialField(FieldDefinition fieldDef) => 
+            fieldDef.FieldType.Name == "SqlGeography" || fieldDef.FieldType.Name == "SqlGeometry";
     }
 }

src/ServiceStack.OrmLite.SqlServerTests/Converters/ConvertersOrmLiteTestBase.cs

@@ -40,10 +40,12 @@ public void Log(string text)
             Console.WriteLine(text);
         }
 
-        public virtual IDbConnection OpenDbConnection(string connString = null)
+        public virtual IDbConnection OpenDbConnection(string connString = null, IOrmLiteDialectProvider dialectProvider = null)
         {
+            dialectProvider = dialectProvider ?? OrmLiteConfig.DialectProvider;
             connString = connString ?? ConnectionString;
-            return connString.OpenDbConnection();
+
+            return new OrmLiteConnectionFactory(connString, dialectProvider).OpenDbConnection();
         }
     }
 }

src/ServiceStack.OrmLite.SqlServerTests/Expressions/ExpressionsTestBase.cs

@@ -16,12 +16,14 @@ public void Setup()
         //Avoid painful refactor to change all tests to use a using pattern
         private IDbConnection db;
 
-        public override IDbConnection OpenDbConnection(string connString = null)
+        public override IDbConnection OpenDbConnection(string connString = null, IOrmLiteDialectProvider dialectProvider = null)
         {
+            dialectProvider = dialectProvider ?? OrmLiteConfig.DialectProvider;
+
             if (db != null && db.State != ConnectionState.Open)
                 db = null;
 
-            return db ?? (db = base.OpenDbConnection(connString));
+            return db ?? (db = base.OpenDbConnection(connString, dialectProvider));
         }
 
         [TearDown]

src/ServiceStack.OrmLite.SqlServerTests/Issues/DeleteWithGeoTypesIssue.cs

@@ -34,7 +34,7 @@ public void Can_delete_entity_with_Geo_Type()
                 var bar = db.Single<ModelWithGeo>(x => x.Name == "Bar");
                 db.SqlScalar<int>(
                     "DELETE FROM ModelWithGeo WHERE Id=@Id AND Location.STEquals(@Location) = 1", 
-                    new { bar.Id, bar.Name, bar.Location });
+                    new { Id = bar.Id, Location = bar.Location });
 
                 Assert.That(db.Select<ModelWithGeo>().Count, Is.EqualTo(2));
 

src/ServiceStack.OrmLite.SqlServerTests/OrmLiteTestBase.cs

@@ -24,10 +24,11 @@ public void Log(string text)
             Console.WriteLine(text);
         }
 
-        public virtual IDbConnection OpenDbConnection(string connString = null)
+        public virtual IDbConnection OpenDbConnection(string connString = null, IOrmLiteDialectProvider dialectProvider = null)
         {
+            dialectProvider = dialectProvider ?? OrmLiteConfig.DialectProvider;
             connString = connString ?? ConnectionString;
-            return connString.OpenDbConnection();
+            return new OrmLiteConnectionFactory(connString, dialectProvider).OpenDbConnection();
         }
     }
 }

src/ServiceStack.OrmLite/OrmLiteDialectProviderBase.cs

@@ -764,7 +764,12 @@ public virtual bool PrepareParameterizedUpdateStatement<T>(IDbCommand cmd, IColl
                     if (sql.Length > 0)
                         sql.Append(", ");
 
-                    AppendFieldCondition(sql, fieldDef, cmd);
+                    sql
+                        .Append(GetQuotedColumnName(fieldDef.FieldName))
+                        .Append("=")
+                        .Append(this.GetParam(SanitizeFieldNameForParamName(fieldDef.FieldName)));
+
+                    AddParameter(cmd, fieldDef);
                 }
                 catch (Exception ex)
                 {
@@ -782,6 +787,13 @@ public virtual bool PrepareParameterizedUpdateStatement<T>(IDbCommand cmd, IColl
             return hadRowVesion;
         }
 
+        public virtual void AppendNullFieldCondition(StringBuilder sqlFilter, FieldDefinition fieldDef)
+        {
+            sqlFilter
+                .Append(GetQuotedColumnName(fieldDef.FieldName))
+                .Append(" IS NULL");
+        }
+
         public virtual void AppendFieldCondition(StringBuilder sqlFilter, FieldDefinition fieldDef, IDbCommand cmd)
         {
             sqlFilter
@@ -827,9 +839,7 @@ public virtual bool PrepareParameterizedDeleteStatement<T>(IDbCommand cmd, IDict
                     }
                     else
                     {
-                        sqlFilter
-                            .Append(GetQuotedColumnName(fieldDef.FieldName))
-                            .Append(" IS NULL");
+                        AppendNullFieldCondition(sqlFilter, fieldDef);
                     }
                 }
                 catch (Exception ex)