Change floats to use InvariantCulture

mythz · mythz · commit fbbf7d8dfebb · 2015-08-24T06:46:19.000+08:00
diff --git a/src/ServiceStack.OrmLite.Oracle/Converters/OracleFloatConverters.cs b/src/ServiceStack.OrmLite.Oracle/Converters/OracleFloatConverters.cs
@@ -1,4 +1,5 @@
 ﻿using System;
+using System.Globalization;
 using ServiceStack.OrmLite.Converters;
 
 namespace ServiceStack.OrmLite.Oracle.Converters
@@ -12,7 +13,7 @@ public override string ColumnDefinition
 
         public override string ToQuotedString(Type fieldType, object value)
         {
-            var s = value.ToString();
+            var s = ((float)value).ToString(CultureInfo.InvariantCulture);
             if (s.Length > 20) s = s.Substring(0, 20);
             return "'" + s + "'"; // when quoted exception is more clear!
         }
@@ -27,7 +28,7 @@ public override string ColumnDefinition
 
         public override string ToQuotedString(Type fieldType, object value)
         {
-            var s = value.ToString();
+            var s = ((double)value).ToString(CultureInfo.InvariantCulture);
             if (s.Length > 20) s = s.Substring(0, 20);
             return "'" + s + "'"; // when quoted exception is more clear!
         }
@@ -39,7 +40,7 @@ public OracleDecimalConverter() : base(18, 12) {}
 
         public override string ToQuotedString(Type fieldType, object value)
         {
-            var s = value.ToString();
+            var s = ((decimal)value).ToString(CultureInfo.InvariantCulture);
             if (s.Length > 20) s = s.Substring(0, 20);
             return "'" + s + "'"; // when quoted exception is more clear!
         }

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`using System;`
	`2`	`+using System.Globalization;`
`2`	`3`	`using ServiceStack.OrmLite.Converters;`
`3`	`4`
`4`	`5`	`namespace ServiceStack.OrmLite.Oracle.Converters`
`@@ -12,7 +13,7 @@ public override string ColumnDefinition`
`12`	`13`
`13`	`14`	`public override string ToQuotedString(Type fieldType, object value)`
`14`	`15`	`{`
`15`		`- var s = value.ToString();`
	`16`	`+ var s = ((float)value).ToString(CultureInfo.InvariantCulture);`
`16`	`17`	`if (s.Length > 20) s = s.Substring(0, 20);`
`17`	`18`	`return "'" + s + "'"; // when quoted exception is more clear!`
`18`	`19`	`}`
`@@ -27,7 +28,7 @@ public override string ColumnDefinition`
`27`	`28`
`28`	`29`	`public override string ToQuotedString(Type fieldType, object value)`
`29`	`30`	`{`
`30`		`- var s = value.ToString();`
	`31`	`+ var s = ((double)value).ToString(CultureInfo.InvariantCulture);`
`31`	`32`	`if (s.Length > 20) s = s.Substring(0, 20);`
`32`	`33`	`return "'" + s + "'"; // when quoted exception is more clear!`
`33`	`34`	`}`
`@@ -39,7 +40,7 @@ public OracleDecimalConverter() : base(18, 12) {}`
`39`	`40`
`40`	`41`	`public override string ToQuotedString(Type fieldType, object value)`
`41`	`42`	`{`
`42`		`- var s = value.ToString();`
	`43`	`+ var s = ((decimal)value).ToString(CultureInfo.InvariantCulture);`
`43`	`44`	`if (s.Length > 20) s = s.Substring(0, 20);`
`44`	`45`	`return "'" + s + "'"; // when quoted exception is more clear!`
`45`	`46`	`}`