Merge pull request #239 from joelharkes/master

Fixed Interface usage IRemoveByPattern | Add documentation | Tiny perf on  removeByPattern

Author: mythz

src/ServiceStack.Redis/RedisClient.ICacheClient.cs

@@ -20,7 +20,7 @@
 namespace ServiceStack.Redis
 {
     public partial class RedisClient
-        : ICacheClient, IRemoveByPattern
+        : ICacheClient
     {
         public T Exec<T>(Func<RedisClient, T> action)
         {

src/ServiceStack.Redis/RedisClient.cs

@@ -19,6 +19,7 @@
 using ServiceStack.Redis.Generic;
 using ServiceStack.Redis.Pipeline;
 using ServiceStack.Text;
+using ServiceStack.Caching;
 
 namespace ServiceStack.Redis
 {
@@ -30,7 +31,7 @@ namespace ServiceStack.Redis
     ///		 RedisClient.Sets => ICollection[string]
     /// </summary>
     public partial class RedisClient
-        : RedisNativeClient, IRedisClient
+        : RedisNativeClient, IRedisClient, IRemoveByPattern // IRemoveByPattern is implemented in this file.
     {
         public RedisClient()
         {
@@ -990,9 +991,9 @@ public string LoadLuaScript(string body)
 
         public void RemoveByPattern(string pattern)
         {
-            List<string> keys = Keys(pattern).ToStringList();
-            if (keys.Count > 0)
-                Del(keys.ToArray());
+            var keys = Keys(pattern).ToStringArray();
+            if (keys.Length > 0)
+                Del(keys);
         }
 
         public void RemoveByRegex(string pattern)
@@ -1118,6 +1119,7 @@ private static RedisServerRole ToServerRole(string roleName)
                     return RedisServerRole.Unknown;
             }
         }
+        
     }
 
 }

src/ServiceStack.Redis/RedisClientManagerCacheClient.cs

@@ -181,19 +181,24 @@ public void RemoveByPattern(string pattern)
         {
             using (var client = GetClient())
             {
-                var redisClient = client as RedisClient;
+                var redisClient = client as IRemoveByPattern;
                 if (redisClient != null)
                 {
-                    List<string> keys = redisClient.Keys(pattern).ToStringList();
-                    if (keys.Count > 0)
-                        redisClient.Del(keys.ToArray());
+                    redisClient.RemoveByPattern(pattern);
                 }
             }
         }
 
         public void RemoveByRegex(string pattern)
         {
-            RemoveByPattern(pattern.Replace(".*", "*").Replace(".+", "?"));
+            using (var client = GetClient())
+            {
+                var redisClient = client as IRemoveByPattern;
+                if (redisClient != null)
+                {
+                    redisClient.RemoveByRegex(pattern);
+                }
+            }
         }
 
         public TimeSpan? GetTimeToLive(string key)

src/ServiceStack.Redis/RedisManagerPool.cs

@@ -11,20 +11,30 @@
 
 namespace ServiceStack.Redis
 {
+    ///<summary>
+    /// Configuration class for the RedisManagerPool
+    ///</summary>
     public class RedisPoolConfig
     {
+        /// <summary>
+        /// Default pool size used by every new instance of <see cref="RedisPoolConfig"/>. (default: 40)
+        /// </summary>
         public static int DefaultMaxPoolSize = 40;
 
         public RedisPoolConfig()
         {
+            // maybe a bit overkill? could be deprecated if you add max int on RedisManagerPool
             MaxPoolSize = RedisConfig.DefaultMaxPoolSize ?? DefaultMaxPoolSize;
         }
 
+        /// <summary>
+        /// Maximum ammount of <see cref="ICacheClient"/>s created by the <see cref="RedisManagerPool"/>.
+        /// </summary>
         public int MaxPoolSize { get; set; }
     }
 
     /// <summary>
-    /// Provides thread-safe pooling of redis client connections.
+    /// Provides thread-safe pooling of redis client connections. All connections are treaded as read and write hosts.
     /// </summary>
     public partial class RedisManagerPool
         : IRedisClientsManager, IRedisFailover, IHandleClientDispose, IHasRedisResolver

src/ServiceStack.Redis/RedisNativeClient.cs

@@ -28,7 +28,11 @@ namespace ServiceStack.Redis
     /// This class contains all the common operations for the RedisClient.
     /// The client contains a 1:1 mapping of c# methods to redis operations of the same name.
     ///
-    /// Not threadsafe use a pooled manager
+    /// Not threadsafe, use a pooled manager!
+    /// All redis calls on a single instances write to the same Socket.
+    /// If used in multiple threads (or async Tasks) at the same time you will find
+    /// that commands are not executed properly by redis and Servicestack wont be able to (json) serialize 
+    /// the data that comes back.
     /// </summary>
     public partial class RedisNativeClient
         : IRedisNativeClient