Make ICollection behave the same as IEnumerable

Wim Pool · Wim Pool · commit 0f2ad9d9aa7e · 2013-08-08T13:45:48.000+02:00
diff --git a/src/ServiceStack.Text/Common/JsReader.cs b/src/ServiceStack.Text/Common/JsReader.cs
@@ -85,7 +85,7 @@ private ParseStringDelegate GetCoreParseFn<T>()
             }
 #endif
 
-            var isDictionary = typeof(T) != typeof(IEnumerable)
+            var isDictionary = typeof(T) != typeof(IEnumerable) && typeof(T) != typeof(ICollection)
                 && (typeof(T).AssignableFrom(typeof(IDictionary)) || typeof(T).HasInterface(typeof(IDictionary)));
             if (isDictionary)
             {
@@ -124,4 +124,4 @@ private ParseStringDelegate GetCoreParseFn<T>()
         }
 
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ private ParseStringDelegate GetCoreParseFn<T>()`
`85`	`85`	`}`
`86`	`86`	`#endif`
`87`	`87`
`88`		`- var isDictionary = typeof(T) != typeof(IEnumerable)`
	`88`	`+ var isDictionary = typeof(T) != typeof(IEnumerable) && typeof(T) != typeof(ICollection)`
`89`	`89`	`&& (typeof(T).AssignableFrom(typeof(IDictionary)) \|\| typeof(T).HasInterface(typeof(IDictionary)));`
`90`	`90`	`if (isDictionary)`
`91`	`91`	`{`
`@@ -124,4 +124,4 @@ private ParseStringDelegate GetCoreParseFn<T>()`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`}`
`127`		`-}`
	`127`	`+}`