Fix [] covnert to string errpr

Author: mythz

src/ServiceStack.Text/AutoMappingUtils.cs

@@ -96,7 +96,7 @@ public static T CreateCopy<T>(this T from)
             if (typeof(T).IsValueType)
                 return (T)ChangeValueType(from, typeof(T));
 
-            if (typeof(IEnumerable).IsAssignableFrom(typeof(T)))
+            if (typeof(IEnumerable).IsAssignableFrom(typeof(T)) && typeof(T) != typeof(string))
             {
                 var listResult = TranslateListWithElements.TryTranslateCollections(from.GetType(), typeof(T), from);
                 return (T)listResult;
@@ -140,6 +140,9 @@ public static object ConvertTo(this object from, Type toType, bool skipConverter
             if (from is ReadOnlyMemory<char> rom)
                 return TypeSerializer.DeserializeFromSpan(toType, rom.Span);
 
+            if (toType == typeof(string))
+                return from.ToJsv();
+            
             if (typeof(IEnumerable).IsAssignableFrom(toType))
             {
                 var listResult = TryConvertCollections(fromType, toType, from);
@@ -962,7 +965,7 @@ public static GetMemberDelegate CreateTypeConverter(Type fromType, Type toType)
                 if (underlyingToType.IsIntegerType())
                     return fromValue => Convert.ChangeType(fromValue, underlyingToType, null);
             }
-            else if (typeof(IEnumerable).IsAssignableFrom(fromType))
+            else if (typeof(IEnumerable).IsAssignableFrom(fromType) && underlyingToType != typeof(string))
             {
                 return fromValue => AutoMappingUtils.TryConvertCollections(fromType, underlyingToType, fromValue);
             }
@@ -976,6 +979,8 @@ public static GetMemberDelegate CreateTypeConverter(Type fromType, Type toType)
                 {
                     if (fromValue == null)
                         return fromValue;
+                    if (toType == typeof(string))
+                        return fromValue.ToJsv();
 
                     var toValue = toType.CreateInstance();
                     toValue.PopulateWith(fromValue);

src/ServiceStack.Text/TranslateListWithElements.cs

@@ -27,8 +27,7 @@ private static Dictionary<Type, ConvertInstanceDelegate> TranslateICollectionCac
 
         public static object TranslateToGenericICollectionCache(object from, Type toInstanceOfType, Type elementType)
         {
-            ConvertInstanceDelegate translateToFn;
-            if (TranslateICollectionCache.TryGetValue(toInstanceOfType, out translateToFn))
+            if (TranslateICollectionCache.TryGetValue(toInstanceOfType, out var translateToFn))
                 return translateToFn(from, toInstanceOfType);
 
             var genericType = typeof(TranslateListWithElements<>).MakeGenericType(elementType);
@@ -39,8 +38,9 @@ public static object TranslateToGenericICollectionCache(object from, Type toInst
             do
             {
                 snapshot = TranslateICollectionCache;
-                newCache = new Dictionary<Type, ConvertInstanceDelegate>(TranslateICollectionCache);
-                newCache[elementType] = translateToFn;
+                newCache = new Dictionary<Type, ConvertInstanceDelegate>(TranslateICollectionCache) {
+                    [elementType] = translateToFn
+                };
 
             } while (!ReferenceEquals(
                 Interlocked.CompareExchange(ref TranslateICollectionCache, newCache, snapshot), snapshot));
@@ -55,8 +55,7 @@ public static object TranslateToConvertibleGenericICollectionCache(
             object from, Type toInstanceOfType, Type fromElementType)
         {
             var typeKey = new ConvertibleTypeKey(toInstanceOfType, fromElementType);
-            ConvertInstanceDelegate translateToFn;
-            if (TranslateConvertibleICollectionCache.TryGetValue(typeKey, out translateToFn)) return translateToFn(from, toInstanceOfType);
+            if (TranslateConvertibleICollectionCache.TryGetValue(typeKey, out var translateToFn)) return translateToFn(from, toInstanceOfType);
 
             var toElementType = toInstanceOfType.FirstGenericType().GetGenericArguments()[0];
             var genericType = typeof(TranslateListWithConvertibleElements<,>).MakeGenericType(fromElementType, toElementType);
@@ -67,8 +66,9 @@ public static object TranslateToConvertibleGenericICollectionCache(
             do
             {
                 snapshot = TranslateConvertibleICollectionCache;
-                newCache = new Dictionary<ConvertibleTypeKey, ConvertInstanceDelegate>(TranslateConvertibleICollectionCache);
-                newCache[typeKey] = translateToFn;
+                newCache = new Dictionary<ConvertibleTypeKey, ConvertInstanceDelegate>(TranslateConvertibleICollectionCache) {
+                    [typeKey] = translateToFn
+                };
 
             } while (!ReferenceEquals(
                 Interlocked.CompareExchange(ref TranslateConvertibleICollectionCache, newCache, snapshot), snapshot));
@@ -109,23 +109,23 @@ public static object TryTranslateCollections(Type fromPropertyType, Type toPrope
     public class ConvertibleTypeKey
     {
         public Type ToInstanceType { get; set; }
-        public Type FromElemenetType { get; set; }
+        public Type FromElementType { get; set; }
 
         public ConvertibleTypeKey()
         {
         }
 
-        public ConvertibleTypeKey(Type toInstanceType, Type fromElemenetType)
+        public ConvertibleTypeKey(Type toInstanceType, Type fromElementType)
         {
             ToInstanceType = toInstanceType;
-            FromElemenetType = fromElemenetType;
+            FromElementType = fromElementType;
         }
 
         public bool Equals(ConvertibleTypeKey other)
         {
             if (ReferenceEquals(null, other)) return false;
             if (ReferenceEquals(this, other)) return true;
-            return Equals(other.ToInstanceType, ToInstanceType) && Equals(other.FromElemenetType, FromElemenetType);
+            return other.ToInstanceType == ToInstanceType && other.FromElementType == FromElementType;
         }
 
         public override bool Equals(object obj)
@@ -141,7 +141,7 @@ public override int GetHashCode()
             unchecked
             {
                 return ((ToInstanceType != null ? ToInstanceType.GetHashCode() : 0) * 397)
-                    ^ (FromElemenetType != null ? FromElemenetType.GetHashCode() : 0);
+                    ^ (FromElementType != null ? FromElementType.GetHashCode() : 0);
             }
         }
     }

tests/ServiceStack.Text.Tests/AutoMappingTests.cs

@@ -873,5 +873,11 @@ public void Translate_Between_Models_of_nullables_and_different_types()
             ModelWithFieldsOfDifferentTypesAsNullables.AssertIsEqual(toObj, fromObj);
         }
 
+        [Test]
+        public void Can_convert_to_array_to_string()
+        {
+            Assert.That(new []{ new ViewModel { Public = "A"} }.ConvertTo<string>(), Is.Not.Empty);
+            Assert.That(new []{ DayOfWeek.Monday }.ConvertTo<string>(), Is.Not.Empty);
+        }
     }
 }