Change TimeSpan to use decimals to not lose precision during deserialization

Author: mythz

src/ServiceStack.Text/Support/TimeSpanConverter.cs

@@ -54,7 +54,7 @@ public static TimeSpan FromXsdDuration(string xsdDuration)
             int days = 0;
             int hours = 0;
             int minutes = 0;
-            double seconds = 0;
+            decimal seconds = 0;
             int sign = 1;
 
             if (xsdDuration.StartsWith("-", StringComparison.Ordinal))
@@ -95,13 +95,13 @@ public static TimeSpan FromXsdDuration(string xsdDuration)
                 string[] s = m[m.Length - 1].SplitOnFirst('S');
                 if (s.Length == 2)
                 {
-                    double millis;
-                    if (double.TryParse(s[0], out millis))
+                    decimal millis;
+                    if (decimal.TryParse(s[0], out millis))
                         seconds = millis;
                 }
             }
 
-            double totalSecs = 0
+            decimal totalSecs = 0
                     + (days * 24 * 60 * 60)
                     + (hours * 60 * 60)
                     + (minutes * 60)

tests/ServiceStack.Text.Tests/Utils/DateTimeSerializerTests.cs

@@ -741,6 +741,21 @@ public void Can_Parse_TimeSpan_NSTimeSpan()
             Assert.That("31536000".FromJson<TimeSpan>(), Is.EqualTo(TimeSpan.FromDays(365)));
             Assert.That("31539661.001".FromJson<TimeSpan>(), Is.EqualTo(Time1Y1M1H1S1MS));
         }
+
+        [Test]
+        public void Does_not_lose_precision()
+        {
+            Assert.Multiple(() =>
+            {
+                for (int i = 1; i <= 999; i++)
+                {
+                    TimeSpan timeSpan = new TimeSpan(0, 0, 0, 0, i);
+                    string json = JsonSerializer.SerializeToString(timeSpan);
+                    TimeSpan timeSpanAfter = JsonSerializer.DeserializeFromString<TimeSpan>(json);
+                    Assert.AreEqual(TimeSpan.FromMilliseconds(i), timeSpanAfter);
+                }
+            });
+        }
     }
 
     [TestFixture]