don't by-pass string escaping for strings in Json ITypeSerializing<T>

mythz · mythz · commit 69d2c56e2c5f · 2019-02-19T12:12:36.000-05:00
diff --git a/src/ServiceStack.Text/JsonSerializer.Generic.cs b/src/ServiceStack.Text/JsonSerializer.Generic.cs
@@ -46,7 +46,6 @@ public T DeserializeFromReader(TextReader reader)
         public string SerializeToString(T value)
         {
             if (value == null) return null;
-            if (typeof(T) == typeof(string)) return value as string;
             if (typeof(T) == typeof(object) || typeof(T).IsAbstract || typeof(T).IsInterface)
             {
                 if (typeof(T).IsAbstract || typeof(T).IsInterface) JsState.IsWritingDynamic = true;
@@ -63,11 +62,6 @@ public string SerializeToString(T value)
         public void SerializeToWriter(T value, TextWriter writer)
         {
             if (value == null) return;
-            if (typeof(T) == typeof(string))
-            {
-                writer.Write(value);
-                return;
-            }
             if (typeof(T) == typeof(object) || typeof(T).IsAbstract || typeof(T).IsInterface)
             {
                 if (typeof(T).IsAbstract || typeof(T).IsInterface) JsState.IsWritingDynamic = true;

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,6 @@ public T DeserializeFromReader(TextReader reader)`
`46`	`46`	`public string SerializeToString(T value)`
`47`	`47`	`{`
`48`	`48`	`if (value == null) return null;`
`49`		`- if (typeof(T) == typeof(string)) return value as string;`
`50`	`49`	`if (typeof(T) == typeof(object) \|\| typeof(T).IsAbstract \|\| typeof(T).IsInterface)`
`51`	`50`	`{`
`52`	`51`	`if (typeof(T).IsAbstract \|\| typeof(T).IsInterface) JsState.IsWritingDynamic = true;`
`@@ -63,11 +62,6 @@ public string SerializeToString(T value)`
`63`	`62`	`public void SerializeToWriter(T value, TextWriter writer)`
`64`	`63`	`{`
`65`	`64`	`if (value == null) return;`
`66`		`- if (typeof(T) == typeof(string))`
`67`		`- {`
`68`		`- writer.Write(value);`
`69`		`- return;`
`70`		`- }`
`71`	`65`	`if (typeof(T) == typeof(object) \|\| typeof(T).IsAbstract \|\| typeof(T).IsInterface)`
`72`	`66`	`{`
`73`	`67`	`if (typeof(T).IsAbstract \|\| typeof(T).IsInterface) JsState.IsWritingDynamic = true;`