Change GetRightPart to return null when needle doesn't exist

Author: mythz

src/ServiceStack.Text/StringExtensions.cs

@@ -358,7 +358,7 @@ public static string GetRightPart(this string strVal, char needle)
             if (strVal == null) return null;
             var pos = strVal.IndexOf(needle);
             return pos == -1
-                ? strVal
+                ? null
                 : strVal.Substring(pos + 1);
         }
 
@@ -367,7 +367,7 @@ public static string GetRightPart(this string strVal, string needle)
             if (strVal == null) return null;
             var pos = strVal.IndexOf(needle, StringComparison.OrdinalIgnoreCase);
             return pos == -1
-                ? strVal
+                ? null
                 : strVal.Substring(pos + needle.Length);
         }
 

tests/ServiceStack.Text.Tests/StringExtensionsTests.cs

@@ -22,6 +22,9 @@ public void Can_GetLeftPart_and_GetLeftPart_char_needle()
             var str = "user:pass@w:rd";
             Assert.That(str.GetLeftPart(':'), Is.EqualTo("user"));
             Assert.That(str.GetRightPart(':'), Is.EqualTo("pass@w:rd"));
+
+            Assert.That(str.GetLeftPart('|'), Is.EqualTo("user:pass@w:rd"));
+            Assert.That(str.GetRightPart('|'), Is.Null);
         }
 
         [Test]
@@ -38,6 +41,9 @@ public void Can_GetLeftPart_and_GetLeftPart_string_needle()
             var str = "user::pass@w:rd";
             Assert.That(str.GetLeftPart("::"), Is.EqualTo("user"));
             Assert.That(str.GetRightPart("::"), Is.EqualTo("pass@w:rd"));
+
+            Assert.That(str.GetLeftPart("||"), Is.EqualTo("user::pass@w:rd"));
+            Assert.That(str.GetRightPart("||"), Is.Null);
         }
 
         [Test]